Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added aioredis package to snmp container for supporting linkup/down t… #8130

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

suresh-rupanagudi
Copy link
Contributor

…raps

Why I did it

snmp-subagent needs aioredis package to support linkup/down and config change traps.

How I did it

Using aioredis package used for snmp traps support

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

aioredis package is used to generate linkup/down and config change snmp traps

A picture of a cute animal (not mandatory but encouraged)

@qiluo-msft
Copy link
Collaborator

snmp-subagent needs aioredis package to support linkup/down and config change traps

Could you explain how aioredis was (will be?) used to support linkup/down and config change traps?

@faraazbrcm
Copy link
Contributor

snmp-subagent needs aioredis package to support linkup/down and config change traps

Could you explain how aioredis was (will be?) used to support linkup/down and config change traps?

aioredis is an asynchronous Redis client which the trap infrastructure in SNMP uses. aioredis is more suited for the SNMP sub-agent because it is based on asyncio and asynchronous Redis client is more suited than the synchronous client. Link up/down and config traps are supported using the this trap infrastructure.

@@ -44,7 +44,9 @@ RUN locale-gen
RUN pip3 install --no-cache-dir \
hiredis \
pyyaml \
smbus
smbus \
aioredis==1.3.0 \
Copy link
Collaborator

@qiluo-msft qiluo-msft Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not install the latest version? Is there anything disruptively changed after 1.3.0? #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried with version 2.0.1 and trap generation is not working. We need to debug further to find why its failing.
Version 1.3.0 is working fine.

@suresh-rupanagudi
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants