[TACACS+] Add plugin support to bash. #8660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a draft PR, need apply the diff file to bash source code and pass build. |
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
| From b4962d09ab2d41a5e993bf3d8e4ebe32114999dc Mon Sep 17 00:00:00 2001 | ||
| From: liuh-80 <58683130+liuh-80@users.noreply.github.com> | ||
| Date: Fri, 3 Sep 2021 14:05:36 +0800 | ||
| Subject: [PATCH] Add plugin support to bash. |
There was a problem hiding this comment.
After check with liuxin about the license issue, will submit PR to bash.
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
qiluo-msft
reviewed
Sep 3, 2021
…h-80/sonic-buildimage into dev/liuh/bash_plugin_support # Conflicts: # src/bash/Makefile
qiluo-msft
reviewed
Sep 7, 2021
qiluo-msft
reviewed
Sep 7, 2021
…h-80/sonic-buildimage into dev/liuh/bash_plugin_support
liuh-80
commented
Sep 10, 2021
qiluo-msft
reviewed
Sep 10, 2021
qiluo-msft
reviewed
Sep 10, 2021
qiluo-msft
reviewed
Sep 10, 2021
…h-80/sonic-buildimage into dev/liuh/bash_plugin_support
…h-80/sonic-buildimage into dev/liuh/bash_plugin_support
qiluo-msft
reviewed
Sep 18, 2021
rules/bash.mk
Outdated
| # Bash complete release-number. This image contains all 4.3 fixes up to patch '42'. | ||
| BASH_VERSION_FULL = $(BASH_VERSION_MAJOR)-14 | ||
| # Bash major release-number corresponding to Debian-10 (Buster) | ||
| BASH_VERSION_MAJOR = 5.0 |
There was a problem hiding this comment.
Bullseye using 5.1-2+b3 version: https://packages.debian.org/stable/shells/bash
will change to this version.
qiluo-msft
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add plugin support library to bash.
And we will create a TACACS+ plugin for bash in an other PR, which will bring per command authorization feature to bash.
Why I did it
To support TACACS per command authorization, we check user command before execute it.
How I did it
Add plugin support to bash.
How to verify it
UT with CUnit under bash project cover all new code in plugin.c.
Also pass all current UT.
Which release branch to backport (provide reason below if selected)
N/A
Description for the changelog
Add plugin support to bash.
A picture of a cute animal (not mandatory but encouraged)