-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect against telemetry container restarts when config fields do not exist #9263
base: master
Are you sure you want to change the base?
Conversation
/azp run |
Commenter does not have sufficient privileges for PR 9263 in repo Azure/sonic-buildimage |
@lguohan could you review this fix, or find someone to do so please? |
@lguohan could you find us a reviewer for this PR please? |
@lguohan please can you review this PR? |
@rlhui could you help us find a reviewer for this PR? @AidanCopeland could you comment "/azpw run" to retry the pipeline? |
/azpw run |
/AzurePipelines run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
@lguohan are you able to review this PR or suggest a reviewer for us? |
@qiluo-msft Are you able to review this PR (Rita suggested I ask you). |
@yozhao101 Please help review this PR. |
Acked and will review. |
@qiluo-msft and @yozhao101 : Thanks for following up. |
We have another PR under reviewing: https://github.com/Azure/sonic-buildimage/pull/9600/files which can fix the issue addressed in this PR. |
We have another PR under reviewing: https://github.com/Azure/sonic-buildimage/pull/9600/files which can fix the issue addressed in this PR. |
[dockers] Protect against telemetry container restarts when config fields do not exist
What I did
This PR fixes a bug in jq handling in the case where a lookup is made for a field that does not exist or is empty
Why I did it
Without this fix the telemetry container continually restarts until it hits the restart limit
How I did it
Provide additional checks against "null", being the value returned by jq if the field does not exist or is empty
How to verify it
Verified in internal testing with framewave
Description for the changelog
Fix handling of jq lookups for empty or non-existent fields
A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Aidan Copeland acopeland@microsoft.com