Showtech sonic mgmt framework: Add Management Framework functionality for "show tech-support" #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 14, 2021 23:34
Add definitions for mgmt common host APIs.
4 tasks
…eld. These changes make use of an additional output field for the "show tech-support" command. The corresponding output-status leaf is added to the set of output leaves in the Yang definition for the sonic-show-techsupport module. This additional field is specified in the SONiC Community HLD for the Management Framework "show tech-support" feature, but was not present in the initial implementation of the feature. The purpose of the additional field is to provide an indication of "success" or detailed failure status that is separate from the output-filename field. With this change, the output-filename contains either an output filename or a null string, and is no longer used to describe errors in the event of a failure.
|
Hi @renukamanavalan - could you please review and merge, thanks |
|
reviewed |
leeprecy
approved these changes
Oct 21, 2021
lguohan
reviewed
Nov 11, 2021
| @@ -0,0 +1,17 @@ | |||
| module sonic-showtech-annot { | |||
There was a problem hiding this comment.
why these yang model not in sonic-yang-model in build image?
There was a problem hiding this comment.
We use RPC (to invoke internal Click command via d-bus infra) for show-tech operation from mgmt-framework and no config-DB update here and hence no YANG model is present in sonic-yang-model in build image.
|
Looks good to me. |
venkatmahalingam
approved these changes
Nov 23, 2021
This file contained commented out code to provide examples of synchronous and asynchronous invocation of the "HostQuery" and "HostQueryAsync" functions. The examples are being deleted from this file to eliminate a block of commented out code. The equivalent information should, instead, be provided in the "SONiC_Host_Services_Developer_Guide" document.
renukamanavalan
requested review from
sujinmkang
and removed request for
jleveque
|
@sujinmkang, Can you please help with the review? |
sujinmkang
approved these changes
Jan 14, 2022
renukamanavalan
pushed a commit
to sonic-net/sonic-mgmt-framework
that referenced
this pull request
Jan 20, 2022
… for "show tech-support" (#86) Provide the changes required for supporting the "show-techsupport" command via the SONiC Management Framework front end mechanisms (CLI, REST, and gNOI). The Management Framework functionality implemented by this PR improves on the the capabilities currently provided by the SONiC Click CLI interface via the "show techsupport" command by providing the following additional features: User-friendly "help" information describing command syntax details for CLI invocation. Ability to invoke the command via REST and gNOI mechanisms. Unit test results are attached to this PR. unit_test_log_0607.txt Corequisite PRs: sonic-net/sonic-mgmt-common#49
dell-engops
pushed a commit
to project-arlo/sonic-mgmt-common
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide the changes required for supporting the "show-techsupport" command via the SONiC Management Framework front end mechanisms (CLI, REST, and gNOI). The Management Framework functionality implemented by this PR improves on the the capabilities currently provided by the SONiC Click CLI interface via the "show techsupport" command by providing the following additional features:
Unit test results are attached to this PR.
unit_test_log_0607.txt
Corequisite PRs:
sonic-net/sonic-telemetry#78
sonic-net/sonic-telemetry#79