Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DUT resources monitoring feature. #1121

Merged
merged 5 commits into from
Oct 8, 2019

Conversation

yvolynets-mlnx
Copy link
Contributor

Signed-off-by: Yuriy Volynets yuriyv@mellanox.com

Description of PR

Summary: DUT hardware resources monitoring feature based on HLD
Fixes #

Type of change

  • [] Bug fix
  • [+] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

Added new pytest plugin, which triggers device HW resources monitoring on the DUT.

How did you verify/test it?

Tested on the local setup, with intentionally changed thresholds in the configuration file to trigger thresholds exceed errors.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>
tests/plugins/dut_monitor/dut_monitor.py Outdated Show resolved Hide resolved
tests/plugins/dut_monitor/dut_monitor.py Show resolved Hide resolved
tests/plugins/dut_monitor/dut_monitor.py Outdated Show resolved Hide resolved
tests/plugins/dut_monitor/dut_monitor.py Show resolved Hide resolved
tests/plugins/dut_monitor/dut_monitor.py Outdated Show resolved Hide resolved
tests/plugins/dut_monitor/dut_monitor.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@wangxin wangxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the DUT is rebooted during testing, it looks like the dut_monitor.py script on DUT would not start running again. Is there a way to restart it after rebooting?

@yvolynets-mlnx
Copy link
Contributor Author

If the DUT is rebooted during testing, it looks like the dut_monitor.py script on DUT would not start running again. Is there a way to restart it after rebooting?

"DUTMonitorClient" class takes care of it. It will automatically restart monitoring script when device become accessible.

@prsunny
Copy link
Contributor

prsunny commented Sep 27, 2019

A general question on this DUT monitor, can we also plan to have CRM monitoring here. For eg, if any alarms/warnings are raised for CRM resources. May be as a phase 2 commit?

yvolynets-mlnx and others added 2 commits October 1, 2019 12:42
Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>
tests/plugins/dut_monitor/thresholds.yml Outdated Show resolved Hide resolved
tests/plugins/dut_monitor/thresholds.yml Outdated Show resolved Hide resolved
@lguohan lguohan merged commit 2e72bb7 into sonic-net:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants