[Y-Cable][Broadcom] Broadcom implementation of YCable class which inherits from YCableBase required for Y-Cable API's in sonic-platform-daemons #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 42 alerts when merging b56a60b into e168f1d - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging dd6ff1b into e168f1d - view on LGTM.com new alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
lguohan
previously approved these changes
Jul 26, 2021
|
converting it as a draft, since the implementations has few work items/fixes |
prgeor
previously approved these changes
Jul 29, 2021
… into braodcom_changes
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 42 alerts when merging 42391d8 into cd3cca7 - view on LGTM.com new alerts:
|
vdahiya12
force-pushed
the
braodcom_changes
branch
from
227c21c
to
42391d8
Compare
… into braodcom_changes Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 42 alerts when merging 42391d8 into ce51894 - view on LGTM.com new alerts:
|
…-platform-common into braodcom_changes
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
lguohan
approved these changes
Aug 23, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 25, 2021
…erits from YCableBase required for Y-Cable API's in sonic-platform-daemons (#208) This PR adds support for YCable class required for platform-daemons to use the YCable API's for Broadcom. Description Basically a vendor specific implementation of abstract YCableBase class . detailed design discussion can be found https://github.com/Azure/SONiC/pull/757/files Motivation and Context Required for transitioning to vendor agnostic API's to be called by xcvrd, so that all types of cables can be called. How Has This Been Tested? Ran the changes on Arista7050cx3 switch, making changes inside the container. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…to the State-DB (sonic-net#208) fix for logging the xcvrd metrics before writing the state back to the STATE DB Description This PR fixes the logging for mux_metrics for writing anything to the state DB for a state transition. Basically previously xcvrd would first post the query result to the DB and only then update its own metric for state transition, but now we do the reverse. Motivation and Context Second change was motivated by the sequence of events which happen inside state transition for mux-metrics table. Previously orchagent reports finishing the transition before xcvrd which is not the case. Ideally xcvrd does the transition first followed by orchagent followed by linkmgr How Has This Been Tested? Ran the change on Arista7050cx3 testbed. Additional Information (Optional) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for YCable class required for platform-daemons to use the YCable API's for Broadcom.
Description
Basically a vendor specific implementation of abstract YCableBase class .
detailed design discussion can be found https://github.com/Azure/SONiC/pull/757/files
Motivation and Context
Required for transitioning to vendor agnostic API's to be called by xcvrd, so that all types of cables can be called.
How Has This Been Tested?
Ran the changes on Arista7050cx3 switch, making changes inside the container.
Additional Information (Optional)
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com