Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sub interface CONFIG_DB schema #284

Merged
merged 4 commits into from
Sep 3, 2019
Merged

Add sub interface CONFIG_DB schema #284

merged 4 commits into from
Sep 3, 2019

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Jun 19, 2019 •
edited
Loading

Proposed:

    "VLAN_SUB_INTERFACE": {
        "Ethernet29.10": {
            "admin_status" : "up"
        },
        "Ethernet29.10|192.168.0.1/21": {}
    },

Parsing logic:
Name before dot is the parent interface Ethernet29. Name after dot is the dot1q encapsulation vlan id 10.

Signed-off-by: Wenda Ni wenni@microsoft.com

HLD: sonic-net/SONiC#420

@wendani
Add sub interface CONFIG_DB schema
68b0c05 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani wendani requested review from stcheng, prsunny and lguohan June 19, 2019 02:00
@lguohan
Copy link
Contributor

lguohan commented Jun 19, 2019

can we get the design document first?

lguohan
lguohan requested changes Jun 29, 2019
View reviewed changes
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocker. please submit design doc first.

@wendani wendani mentioned this pull request Jul 12, 2019
Merged
@wendani wendani requested a review from lguohan August 9, 2019 17:22
@lguohan
Copy link
Contributor

lguohan commented Aug 11, 2019

retest this please

@lguohan lguohan merged commit e455891 into sonic-net:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@stcheng stcheng Awaiting requested review from stcheng

@prsunny prsunny Awaiting requested review from prsunny

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wendani @lguohan @stcheng