[Dynamic buffer calc] Support dynamic buffer calculation #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
stephenxs
commented
Jul 1, 2020
stephenxs
commented
- Database schema updates.
- Move the json file parsing from swss to swss-common.
stephenxs
force-pushed
the
dynamic-buffer-calculation
branch
from
75f9d45
to
2a5e8b9
Compare
stephenxs
changed the title
neethajohn
suggested changes
Sep 10, 2020
stephenxs
force-pushed
the
dynamic-buffer-calculation
branch
from
ee8c149
to
99024ce
Compare
neethajohn
reviewed
Sep 14, 2020
stephenxs
force-pushed
the
dynamic-buffer-calculation
branch
from
99024ce
to
5dc96c2
Compare
stephenxs
force-pushed
the
dynamic-buffer-calculation
branch
from
695f07c
to
4716472
Compare
Signed-off-by: Stephen Sun <stephens@mellanox.com>
component can take advantage of this tool
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
force-pushed
the
dynamic-buffer-calculation
branch
from
4716472
to
4d06910
Compare
liat-grozovik
requested changes
Nov 16, 2020
Signed-off-by: Stephen Sun <stephens@nvidia.com>
liat-grozovik
previously approved these changes
Nov 16, 2020
|
@neetha please review and provide your feedback. this PR is needed to be the first to be merged so other related PRs can be tested properly in Jenkins PR CI |
neethajohn
reviewed
Nov 20, 2020
neethajohn
previously approved these changes
Nov 20, 2020
liat-grozovik
previously approved these changes
Nov 24, 2020
stephenxs
dismissed stale reviews from liat-grozovik and neethajohn
via
3458442
liat-grozovik
previously approved these changes
Nov 24, 2020
|
@neethajohn your approval was lost with the last push. can you please approve and merge? |
neethajohn
previously approved these changes
Nov 24, 2020
qiluo-msft
reviewed
Nov 30, 2020
qiluo-msft
reviewed
Nov 30, 2020
qiluo-msft
reviewed
Nov 30, 2020
qiluo-msft
reviewed
Nov 30, 2020
qiluo-msft
reviewed
Nov 30, 2020
qiluo-msft
reviewed
Nov 30, 2020
qiluo-msft
reviewed
Nov 30, 2020
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
dismissed stale reviews from neethajohn and liat-grozovik
via
ca70649
qiluo-msft
reviewed
Dec 1, 2020
qiluo-msft
reviewed
Dec 1, 2020
Signed-off-by: Stephen Sun <stephens@nvidia.com>
qiluo-msft
reviewed
Dec 1, 2020
Signed-off-by: Stephen Sun <stephens@nvidia.com>
- logic_error for json syntax errors - bas_alloc for insufficient memory Signed-off-by: Stephen Sun <stephens@nvidia.com>
qiluo-msft
reviewed
Dec 2, 2020
qiluo-msft
approved these changes
Dec 2, 2020
|
@qiluo-msft can you please merge? |
liat-grozovik
approved these changes
Dec 2, 2020
3 tasks
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 13, 2020
**- Why I did it** To support dynamic buffer calculation. This PR also depends on the following PRs for sub modules - [sonic-swss: [buffermgr/bufferorch] Support dynamic buffer calculation #1338](sonic-net/sonic-swss#1338) - [sonic-swss-common: Dynamic buffer calculation #361](sonic-net/sonic-swss-common#361) - [sonic-utilities: Support dynamic buffer calculation #973](sonic-net/sonic-utilities#973) **- How I did it** 1. Introduce field `buffer_model` in `DEVICE_METADATA|localhost` to represent which buffer model is running in the system currently: - `dynamic` for the dynamic buffer calculation model - `traditional` for the traditional model in which the `pg_profile_lookup.ini` is used 2. Add the tables required for the feature: - ASIC_TABLE in platform/\<vendor\>/asic_table.j2 - PERIPHERAL_TABLE in platform/\<vendor\>/peripheral_table.j2 - PORT_PERIPHERAL_TABLE on a per-platform basis in device/\<vendor\>/\<platform\>/port_peripheral_config.j2 for each platform with gearbox installed. - DEFAULT_LOSSLESS_BUFFER_PARAMETER and LOSSLESS_TRAFFIC_PATTERN in files/build_templates/buffers_config.j2 - Add lossless PGs (3-4) for each port in files/build_templates/buffers_config.j2 3. Copy the newly introduced j2 files into the image and rendering them when the system starts 4. Update the CLI options for buffermgrd so that it can start with dynamic mode 5. Fetches the ASIC vendor name in orchagent: - fetch the vendor name when creates the docker and pass it as a docker environment variable - `buffermgrd` can use this passed-in variable 6. Clear buffer related tables from STATE_DB when swss docker starts 7. Update the src/sonic-config-engine/tests/sample_output/buffers-dell6100.json according to the buffer_config.j2 8. Remove buffer pool sizes for ingress pools and egress_lossy_pool Update the buffer settings for dynamic buffer calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.