Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ConfigDBPipeConnector]: Added set_entry API #586

Merged
merged 2 commits into from
Mar 11, 2022
Merged

[ConfigDBPipeConnector]: Added set_entry API #586

merged 2 commits into from
Mar 11, 2022

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Mar 4, 2022 •
edited
Loading

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

HLD: sonic-net/SONiC#909

What I did

  • Reworked set_entry to support Redis transactions
  • Added PBH Edit Flows State DB schema

Why I did it

  • Implementation is done according to the PBH HLD

How I verified it

  • N/A

Details if related

  • N/A

@nazariig
[pbh]: Implement Edit Flows.
f6bfaf3 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig nazariig mentioned this pull request Mar 4, 2022
Merged
@nazariig nazariig requested review from anish-n and kktheballer March 4, 2022 19:47
@qiluo-msft
Copy link
Contributor

Suggest change title. This change is a general feature, no need to mention PBH. "Edit Flows" is also not clear to readers.

Checking https://dev.azure.com/mssonic/build/_build/results?buildId=78095&view=codecoverage-tab, could you also add unit test to cover corner case branch?

@nazariig nazariig changed the title [pbh]: Implement Edit Flows [ConfigDBPipeConnector]: Added transaction mode support Mar 7, 2022
@nazariig nazariig changed the title [ConfigDBPipeConnector]: Added transaction mode support [ConfigDBPipeConnector]: Added transactions support Mar 7, 2022
@nazariig
[ConfigDBPipeConnector]: Added UTs to increase code coverage.
ae8ac1a 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig nazariig changed the title [ConfigDBPipeConnector]: Added transactions support [ConfigDBPipeConnector]: Added set_entry API Mar 8, 2022
@nazariig
Copy link
Collaborator Author

nazariig commented Mar 8, 2022

Suggest change title. This change is a general feature, no need to mention PBH. "Edit Flows" is also not clear to readers.

Checking https://dev.azure.com/mssonic/build/_build/results?buildId=78095&view=codecoverage-tab, could you also add unit test to cover corner case branch?

@qiluo-msft review comments are handled

@nazariig
Copy link
Collaborator Author

nazariig commented Mar 8, 2022

@anish-n we need to have this PR merged before moving forward with swss changes. Please review it with a high prio.

@nazariig nazariig requested a review from liat-grozovik March 8, 2022 22:21
@nazariig
Copy link
Collaborator Author

@anish-n just a kind reminder

@anish-n
Copy link
Contributor

anish-n commented Mar 11, 2022

I have reviewed the PR and provided feedback as per my understanding, since I haven't contributed to configdb.cpp/h in the past, request that you get review from someone who typically contributes to these files as well! :)

@qiluo-msft qiluo-msft merged commit e9442bb into sonic-net:master Mar 11, 2022
@nazariig
Copy link
Collaborator Author

I have reviewed the PR and provided feedback as per my understanding, since I haven't contributed to configdb.cpp/h in the past, request that you get review from someone who typically contributes to these files as well! :)

@anish-n thanks a lot for your feedback! Your comments are very valuable - a lot of interesting questions were answered.

judyjoseph pushed a commit that referenced this pull request Mar 20, 2022
@nazariig @judyjoseph
[ConfigDBPipeConnector]: Added set_entry API (#586)
a1abaa8 
**What I did**
* Reworked `set_entry` to support Redis transactions
* Added PBH Edit Flows State DB schema

**Why I did it**
* Implementation is done according to the PBH HLD
@nazariig nazariig mentioned this pull request Mar 31, 2022
Merged
6 tasks
itamar-talmon pushed a commit to itamar-talmon/sonic-swss-common that referenced this pull request Jul 19, 2022
@nazariig @itamar-talmon
[ConfigDBPipeConnector]: Added set_entry API (sonic-net#586)
c6ea1ff 
**What I did**
* Reworked `set_entry` to support Redis transactions
* Added PBH Edit Flows State DB schema

**Why I did it**
* Implementation is done according to the PBH HLD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anish-n anish-n anish-n left review comments

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@kktheballer kktheballer Awaiting requested review from kktheballer

@liat-grozovik liat-grozovik Awaiting requested review from liat-grozovik

Assignees
No one assigned
Labels
Included in 202111 Branch Request for 202111 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nazariig @qiluo-msft @anish-n @judyjoseph