Threshold feature Orch changes. #1067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2019
orchagent/thresholdorch.cpp
Outdated
| } | ||
|
|
||
| /* Create TAM collector object */ | ||
| /* Create TAM collector object */ |
There was a problem hiding this comment.
Remove unwanted code
There was a problem hiding this comment.
Done, have updated latest diff.
AshokDaparthi
previously approved these changes
Nov 27, 2019
|
Changes being tracked via #1545. |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
In azp run, the following failure always happens at the stage of `make check` of building syncd.
```
Making check in syncd
make[2]: Entering directory '/__w/1/s/syncd'
make check-TESTS
make[3]: Entering directory '/__w/1/s/syncd'
tests: tests.cpp:843: void test_watchdog_timer_clock_rollback(): Assertion `settimeofday(¤tTime, NULL) == 0' failed.
/bin/bash: line 5: 13004 Aborted (core dumped) ${dir}$tst
FAIL: tests
```
The execution of `settimeofday(¤tTime, NULL)` fails in slave docker with errno **EPERM**, because CAP_SYS_TIME capability is dropped in docker. Using option `--privileged` gives docker extended privileges for its success.
This failure has existed for a long time in azp build and is not exposed till sonic-net/sonic-sairedis#1050.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…net#1068) The fix sonic-net#1067 is not enough. If docker user is non-root, set capability CAP_SYS_TIME for settimeofday success in syncd test, then test_watchdog_timer_clock_rollback can be run. Co-authored-by: junhuazhai <junhuazhai@contoso.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implemented the threshold feature orch.
Why I did it
Threshold feature brings in support to configure thresholds on a port's PG/queue's buffer usage stat. When the buffer usage crosses the configured threshold, a breach is generated. This PR brings in the orch changes for the threshold feature.
How I verified it
Pytests in tests/test_threshold.py validate the orch changes.
Details if related
Please refer to sonic-net/SONiC@3962074#diff-8c1cef396dfe5dd465889eb11be4106c for the threshold feature HLD.
Depends upon:
sonic-net/sonic-swss-common#310
sonic-net/sonic-utilities#665
Azure/sonic-tam#12
sonic-net/sonic-buildimage#3501