Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPB portsyncd/portmgrd/portorch] Support dynamic port add/deletion without dependencies #1112

Merged
merged 4 commits into from
Feb 6, 2020
Merged

[DPB portsyncd/portmgrd/portorch] Support dynamic port add/deletion without dependencies #1112

merged 4 commits into from
Feb 6, 2020

Conversation

zhenggen-xu
Copy link
Collaborator

@zhenggen-xu zhenggen-xu commented Oct 30, 2019 •
edited
Loading

What I did
Support port add/delete cases in different daemons without dependencies

Why I did it
Baseline code for dynamic port breakout code.

How I verified it
vs test cases

Details if related

Support port add/delete cases in different daemons

Changes were made on portmgrd/portsyncd and orchagent portsorch
so it should be able to remove/add ports in case no configuration
dependencies or runtime depencies (neighbor, mac etc) on them

Also skipped the netlink for port add/delete with master in portsyncd
and cleaned up g_init and g_portSet flag and data strcutures usage.

Added dynamic portbeakout test cases including the conf_test.py changs

Signed-off-by: Zhenggen Xu zxu@linkedin.com
Signed-off-by: Vasant Patil vapatil@linkedin.com

@zhenggen-xu zhenggen-xu changed the title [DRAFT DPB] Support dynamic port deletion without dependencies [DRAFT DPB] Support dynamic port add/deletion without dependencies Oct 30, 2019
@zhenggen-xu zhenggen-xu force-pushed the master-DPB-upstream branch 3 times, most recently from 674e1a0 to 8bae555 Compare November 9, 2019 00:44
@zhenggen-xu zhenggen-xu changed the title [DRAFT DPB] Support dynamic port add/deletion without dependencies [DPB portsyncd/portmgrd/portorch] Support dynamic port add/deletion without dependencies Nov 18, 2019
@zhenggen-xu zhenggen-xu marked this pull request as ready for review November 18, 2019 04:22
@zhenggen-xu
Copy link
Collaborator Author

retest this please!

This was referenced Dec 13, 2019
Closed
Merged
@lguohan lguohan requested a review from qiluo-msft December 16, 2019 22:44
qiluo-msft
qiluo-msft reviewed Dec 18, 2019
View reviewed changes
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
qiluo-msft
qiluo-msft reviewed Dec 18, 2019
View reviewed changes
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
qiluo-msft
qiluo-msft reviewed Dec 18, 2019
View reviewed changes
portsyncd/linksync.cpp Outdated Show resolved Hide resolved
@qiluo-msft qiluo-msft requested a review from lguohan December 18, 2019 23:42
@lguohan
Copy link
Contributor

lguohan commented Jan 29, 2020

retest this please

lguohan
lguohan previously approved these changes Jan 29, 2020
View reviewed changes
@lguohan
Copy link
Contributor

lguohan commented Jan 29, 2020

LGTM

lguohan
lguohan previously approved these changes Jan 31, 2020
View reviewed changes
@zhenggen-xu
Support port add/delete cases in different daemons
81b45a2 
Changes were made on portmgrd/portsyncd and orchagent portsorch
so it should be able to remove/add ports in case no configuration
dependencies or runtime depencies (neighbor, mac etc) on them

Also skipped the netlink for port add/delete with master in portsyncd
and cleaned up g_init and g_portSet flag and data strcutures usage.

Added dynamic portbeakout test cases including the conf_test.py changs

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
Signed-off-by: Vasant Patil <vapatil@linkedin.com>
@zhenggen-xu
Address the review feedback
086f85c 
Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
@zhenggen-xu
Rework after merging to master branch due to PR1170
e45dfb7 
Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
@zhenggen-xu zhenggen-xu dismissed stale reviews from lguohan and qiluo-msft via e45dfb7 January 31, 2020 00:35
@zhenggen-xu
Copy link
Collaborator Author

retest this please

6 similar comments
@daall
Copy link
Contributor

daall commented Feb 5, 2020

retest this please

@daall
Copy link
Contributor

daall commented Feb 5, 2020

retest this please

@daall
Copy link
Contributor

daall commented Feb 5, 2020

retest this please

@daall
Copy link
Contributor

daall commented Feb 5, 2020

retest this please

@zhenggen-xu
Copy link
Collaborator Author

retest this please

@lguohan
Copy link
Contributor

lguohan commented Feb 5, 2020

retest this please

@zhenggen-xu
Skip breakout_all test case for now
4a4c507 
Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
@zhenggen-xu
Copy link
Collaborator Author

retest this please

@lguohan lguohan merged commit 1215262 into sonic-net:master Feb 6, 2020
@samaity samaity mentioned this pull request May 20, 2020
Closed
@samaity samaity mentioned this pull request Jun 4, 2020
Merged
@samaity samaity mentioned this pull request Aug 15, 2020
Merged
kktheballer added a commit to kktheballer/sonic-swss that referenced this pull request Dec 23, 2020
@kktheballer
[DPB portsyncd/portmgrd/portorch] Support dynamic port add/deletion w…
6f3e10d 
…ithout dependencies (sonic-net#1112)

Changes were made on portmgrd/portsyncd and orchagent portsorch
so it should be able to remove/add ports in case no configuration
dependencies or runtime depencies (neighbor, mac etc) on them

Also skipped the netlink for port add/delete with master in portsyncd
and cleaned up g_init and g_portSet flag and data strcutures usage.

Added dynamic portbeakout test cases including the conf_test.py changs

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
Signed-off-by: Vasant Patil <vapatil@linkedin.com>
kktheballer pushed a commit to kktheballer/sonic-swss that referenced this pull request Jan 21, 2021
@zhenggen-xu
[DPB portsyncd/portmgrd/portorch] Support dynamic port add/deletion w…
600f40a 
…ithout dependencies (sonic-net#1112)

Changes were made on portmgrd/portsyncd and orchagent portsorch
so it should be able to remove/add ports in case no configuration
dependencies or runtime depencies (neighbor, mac etc) on them

Also skipped the netlink for port add/delete with master in portsyncd
and cleaned up g_init and g_portSet flag and data strcutures usage.

Added dynamic portbeakout test cases including the conf_test.py changs

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
Signed-off-by: Vasant Patil <vapatil@linkedin.com>
anish-n pushed a commit to anish-n/sonic-swss that referenced this pull request Feb 25, 2021
@zhenggen-xu @anish-n
[DPB portsyncd/portmgrd/portorch] Support dynamic port add/deletion w…
1866ce1 
…ithout dependencies (sonic-net#1112)

Changes were made on portmgrd/portsyncd and orchagent portsorch
so it should be able to remove/add ports in case no configuration
dependencies or runtime depencies (neighbor, mac etc) on them

Also skipped the netlink for port add/delete with master in portsyncd
and cleaned up g_init and g_portSet flag and data strcutures usage.

Added dynamic portbeakout test cases including the conf_test.py changs

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
Signed-off-by: Vasant Patil <vapatil@linkedin.com>
kktheballer pushed a commit to kktheballer/sonic-swss that referenced this pull request Jul 20, 2021
@zhenggen-xu @kktheballer
[DPB portsyncd/portmgrd/portorch] Support dynamic port add/deletion w…
463df09 
…ithout dependencies (sonic-net#1112)

Changes were made on portmgrd/portsyncd and orchagent portsorch
so it should be able to remove/add ports in case no configuration
dependencies or runtime depencies (neighbor, mac etc) on them

Also skipped the netlink for port add/delete with master in portsyncd
and cleaned up g_init and g_portSet flag and data strcutures usage.

Added dynamic portbeakout test cases including the conf_test.py changs

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
Signed-off-by: Vasant Patil <vapatil@linkedin.com>
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
[sflow_test.py]: tests for config sflow commands. (sonic-net#1112)
2cd7893 
* [sflow_test.py]: tests for config sflow commands.

Changes:
-- show sflow use ctx.obj['db'] instead of creating new instance,
   this is must for test, else config change will not be reflected.

-- config SFLOW tests for
   config sflow <enable|disable>
   config sflow agent-id <add | del>
   config sflow collector add|del
   config sflow interface <enable|disable>
   config sflow interface sample-rate
Signed-off-by: Praveen Chaudhary <pchaudhary@linkedin.com>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@stepanblyschak
[SAI] update pointer (sonic-net#636)
d54bfb4 
Changes:
b2487f0 [saithrift] build with recent ctypes (sonic-net#1111)
298344e [saithrift]: Fix max lane per port (sonic-net#1112)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@deran1980 @z80x1
Add Xsight specific syncd start options (sonic-net#1112)
4c9e048 
Signed-off-by: Roman Zhurakivsky <rzhurak@larch-networks.com>

Signed-off-by: Roman Zhurakivsky <rzhurak@larch-networks.com>
Co-authored-by: Roman Zhurakivskyy <rzhurak@larch-networks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@qiluo-msft qiluo-msft qiluo-msft left review comments

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

@volodymyrsamotiy volodymyrsamotiy Awaiting requested review from volodymyrsamotiy

Assignees
No one assigned
Labels
Port Breakout 🔱
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhenggen-xu @lguohan @daall @qiluo-msft @prsunny