[Warmboot] skip teamd reconciliation logic via teamsyncd timer setting #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
dzhangalibaba
force-pushed
the
teamd_reconcile
branch
from
d4d44c9
to
55e0b49
Compare
pavel-shirshov
suggested changes
Jul 29, 2020
teamsyncd/teamsync.cpp
Outdated
| m_lagTable.create_temp_view(); | ||
| m_lagMemberTable.create_temp_view(); | ||
| WarmStart::setWarmStartState(TEAMSYNCD_APP_NAME, WarmStart::INITIALIZED); | ||
| if (m_pending_timeout != MAXIMUM_WARMRESTART_TIMER_VALUE) |
There was a problem hiding this comment.
I'd suggest rename MAXIMUM_WARMRESTART_TIMER_VALUE to NO_WARMRESTART_TIMER_VALUE or DISABLE_WARMRESTART_TIMER_VALUE
There was a problem hiding this comment.
I'd suggest rename MAXIMUM_WARMRESTART_TIMER_VALUE to NO_WARMRESTART_TIMER_VALUE or DISABLE_WARMRESTART_TIMER_VALUE
UPDATED, add DISABLE_WARMRESTART_TIMER_VALUE in swss-common
|
sonic-net/sonic-swss-common#370 needs to be merged first since definition is there |
pavel-shirshov
approved these changes
Jul 30, 2020
|
retest this please |
|
retest this please |
|
sonic-net/sonic-swss-common#370 needs to be merged first . this PR depends on that. |
daall
approved these changes
Jul 31, 2020
daall
suggested changes
Jul 31, 2020
|
Retest this please |
|
retest this please |
|
retest vs please |
|
retest this please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
**- What I did** Added ability to run `show platform firmware` commands without `sudo`, as described in the [design document](https://github.com/Azure/sonic-utilities/blob/master/doc/Command-Reference.md#platform-component-firmware-show-commands): **- How I did it** Made `show platform firmware` implementation run `fwutil` with `sudo` Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com