[intfmgr]: Add GARP support #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When proxy ARP is enabled, also enable arp_accept Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
retest vs please |
This reverts commit d48a2a0.
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
reviewed
Nov 17, 2020
cfgmgr/intfmgr.cpp
Outdated
|
|
||
| if (!alias.compare(0, strlen(VLAN_PREFIX), VLAN_PREFIX)) | ||
| { | ||
| FieldValueTuple fvTuple("arp_accept", grat_arp); |
There was a problem hiding this comment.
The field must be same as what is in config_db - "grat_arp". Lets not change it.
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
retest vs please |
prsunny
approved these changes
Nov 20, 2020
3 tasks
daall
pushed a commit
to daall/sonic-swss
that referenced
this pull request
Dec 7, 2020
* Get `grat_arp` value from config DB and enable kernel `arp_accept` if enabled
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
File show/vlan.py, function config(db) was modified to fill the table with VLAN even without members. Signed-off-by: allas <allas@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interface manager, set
arp_acceptto 1 when gratuitous ARP is enabled for an interface in config DB.Signed-off-by: Lawrence Lee lawlee@microsoft.com
What I did
Why I did it
How I verified it
Details if related