[Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new state: `PORT_ADMIN_DOWN` which represents the port is administratively down. Remove all PGs when the port is shut down and re-add all configured PGs when the port is started up Only record the new value but don't touch `BUFFER_PG_TABLE` if the following events come when a port is administratively down - a port's MTU, speed, or cable length is updated - a new PG is added to a port or an existing PG is removed from a port Optimize the port event handling flow since `refreshPriorityGroupsForPort` should be called only once in case more than one fields are updated Optimize the Lua plugin which calculates the buffer pool size accordingly Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
@stephenxs , can you move out the lua plugin optimizations out of this PR and keep this PR only for the port down bug fix? |
Hi @neethajohn |
neethajohn
approved these changes
Mar 23, 2021
4 tasks
daall
pushed a commit
that referenced
this pull request
Apr 1, 2021
- What I did Bug fixes: Remove PGs from an administratively down port. - Why I did it To fix bugs - How I verified it Run regression and vs test - Details if related Remove PGs from an administratively down port. Introduce a new state: PORT_ADMIN_DOWN which represents the port is administratively down. Remove all PGs when the port is shut down and re-add all configured PGs when port is started up. Only record the new value but don't touch BUFFER_PG_TABLE if the following events come when a port is administratively down a port's MTU, speed, or cable length is updated a new PG is added to a port or an existing PG is removed from a port. Optimize the port event handling flow since refreshPriorityGroupsForPort should be called only once in case more than one fields are updated. Adjust the Lua plugin which calculates the buffer pool size accordingly Signed-off-by: Stephen Sun <stephens@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
- What I did Bug fixes: Remove PGs from an administratively down port. - Why I did it To fix bugs - How I verified it Run regression and vs test - Details if related Remove PGs from an administratively down port. Introduce a new state: PORT_ADMIN_DOWN which represents the port is administratively down. Remove all PGs when the port is shut down and re-add all configured PGs when port is started up. Only record the new value but don't touch BUFFER_PG_TABLE if the following events come when a port is administratively down a port's MTU, speed, or cable length is updated a new PG is added to a port or an existing PG is removed from a port. Optimize the port event handling flow since refreshPriorityGroupsForPort should be called only once in case more than one fields are updated. Adjust the Lua plugin which calculates the buffer pool size accordingly Signed-off-by: Stephen Sun <stephens@nvidia.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
re-enable after fix those tests Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Bug fixes: Remove PGs from an administratively down port.
Signed-off-by: Stephen Sun stephens@nvidia.com
Why I did it
To fix bugs
How I verified it
Run regression and vs test
Which release branch to backport (provide reason below if selected)
Details if related
PORT_ADMIN_DOWNwhich represents the port is administratively down.BUFFER_PG_TABLEif the following events come when a port is administratively downrefreshPriorityGroupsForPortshould be called only once in case more than one fields are updated