Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sFlowMgr] sFlow crash on 200G ports handled #1683

Merged
merged 3 commits into from
Mar 29, 2021
Merged

[sFlowMgr] sFlow crash on 200G ports handled #1683

merged 3 commits into from
Mar 29, 2021

Conversation

vivekrnv
Copy link
Contributor

What I did
Added 200G entry into the speed-rate map. Also handled the case which programs empty string into APP-DB and thus leading to a failure of Orchagent.

Default Sampling rate for 200G is set to 20000

Why I did it
Fix for Issue: sonic-net/sonic-buildimage#6793

How I verified it


root@sonic:/home/admin# show sflow interface 

sFlow interface configurations
+-------------+---------------+-----------------+
| Interface   | Admin State   |   Sampling Rate |
+=============+===============+=================+
| Ethernet0   | up            |           10000 |
+-------------+---------------+-----------------+
| Ethernet8   | up            |           40000 |
+-------------+---------------+-----------------+
| Ethernet16  | up            |           40000 |
+-------------+---------------+-----------------+
| Ethernet24  | up            |           20000 |
+-------------+---------------+-----------------+
| Ethernet28  | up            |           20000 |
+-------------+---------------+-----------------+
| Ethernet32  | up            |           20000 |
+-------------+---------------+-----------------+
| Ethernet36  | up            |           20000 |
+-------------+---------------+-----------------+
| Ethernet40  | up            |           10000 |
+-------------+---------------+-----------------+
| Ethernet42  | up            |           10000 |
+-------------+---------------+-----------------+
<Truncated>

admin@sonic:~$ docker ps -a
CONTAINER ID        IMAGE                                COMMAND                  CREATED             STATUS              PORTS               NAMES
752b20dd8c35        docker-sflow:latest                  "/usr/local/bin/supe…"   5 hours ago         Up 18 minutes                           sflow
e696295db82b        docker-snmp:latest                   "/usr/local/bin/supe…"   5 hours ago         Up 22 minutes                           snmp
d0fc7b5196d5        docker-sonic-mgmt-framework:latest   "/usr/local/bin/supe…"   5 hours ago         Up 22 minutes                           mgmt-framework
fa56887d234f        docker-sonic-telemetry:latest        "/usr/local/bin/supe…"   5 hours ago         Up 22 minutes                           telemetry
b30e1b421d8b        docker-router-advertiser:latest      "/usr/bin/docker-ini…"   5 hours ago         Up 22 minutes                           radv
cbb1b430d2ad        docker-platform-monitor:latest       "/usr/bin/docker_ini…"   5 hours ago         Up 22 minutes                           pmon
b954e4ef41bb        docker-lldp:latest                   "/usr/bin/docker-lld…"   5 hours ago         Up 22 minutes                           lldp
610a476cdfa7        docker-dhcp-relay:latest             "/usr/bin/docker_ini…"   5 hours ago         Up 22 minutes                           dhcp_relay
7f70fb3c1705        docker-syncd-mlnx:latest             "/usr/local/bin/supe…"   5 hours ago         Up 22 minutes                           syncd
8ac03c99f34b        docker-teamd:latest                  "/usr/local/bin/supe…"   5 hours ago         Up 23 minutes                           teamd
9cf4d11bdedf        docker-orchagent:latest              "/usr/bin/docker-ini…"   5 hours ago         Up 23 minutes                           swss
d186df1e6553        docker-fpm-frr:latest                "/usr/bin/docker_ini…"   5 hours ago         Up 23 minutes                           bgp
c847477d8fa7        docker-database:latest               "/usr/local/bin/dock…"   5 hours ago         Up 5 hours                              database


admin@r-leopard-41:~$ show sflow

sFlow Global Information:
  sFlow Admin State:          up
  sFlow Polling Interval:     default
  sFlow AgentID:              default

  0 Collectors configured:

Details if related

@ghost
Copy link

ghost commented Mar 26, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@liat-grozovik liat-grozovik changed the title [SFlowMgr] Sflow Crash on 200G ports handled [sFlowMgr] sFlow Crash on 200G ports handled Mar 29, 2021
@liat-grozovik liat-grozovik changed the title [sFlowMgr] sFlow Crash on 200G ports handled [sFlowMgr] sFlow crash on 200G ports handled Mar 29, 2021
@liat-grozovik liat-grozovik merged commit 15818ad into sonic-net:master Mar 29, 2021
@stephenxs stephenxs mentioned this pull request Mar 30, 2021
Merged
4 tasks
daall pushed a commit that referenced this pull request Apr 1, 2021
@vivekrnv @daall
[SFlowMgr] Sflow Crash on 200G ports handled (#1683)
dad68b5 
- What I did
Added 200G entry into the speed-rate map. Also handled the case which programs empty string into APP-DB and thus leading to a failure of Orchagent.
Default Sampling rate for 200G is set to 20000

- Why I did it
Fix for Issue: sonic-net/sonic-buildimage#6793

- How I verified it
run sflow community test under sonic-mgmt

Co-authored-by: Vivek Reddy Karri <vkarri@nvidia.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
@vivekrnv @raphaelt-nvidia
[SFlowMgr] Sflow Crash on 200G ports handled (sonic-net#1683)
e9f35d8 
- What I did
Added 200G entry into the speed-rate map. Also handled the case which programs empty string into APP-DB and thus leading to a failure of Orchagent.
Default Sampling rate for 200G is set to 20000

- Why I did it
Fix for Issue: sonic-net/sonic-buildimage#6793

- How I verified it
run sflow community test under sonic-mgmt

Co-authored-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv vivekrnv deleted the sflow_crash branch March 18, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

Assignees
No one assigned
Labels
Bug 🐛 Included in 202012 Branch Request for 202012 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivekrnv @liat-grozovik @daall