[orchagent, crm]: Reset crm threshold exceed count when threshold type changed #2073
Conversation
link19430
changed the title
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny could you help to review this PR, thanks |
|
@volodymyrsamotiy , could you please review this? |
|
Changes look good to me. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny @volodymyrsamotiy |
tests/test_crm.py
Outdated
| intf_tbl.set("Ethernet0|10.0.0.0/31", fvs) | ||
| dvs.runcmd("config interface startup Ethernet0") | ||
|
|
||
| dvs.runcmd("crm config polling interval 1") |
There was a problem hiding this comment.
@link19430 , please use crm_update(dvs, "polling_interval", "1") and fix all the CLI command usage. VS tests are modified not use CLI commands. You can take a look at other tests for reference.
There was a problem hiding this comment.
all cli commands had modified to use crm_update()
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…e changed **What I did** Reset crm threshold exceed count when threshold type changed **Why I did it** The issue is that exceed msg not work when exceed count ran out by pervious threshold type. Root cause is that doesn't reset the exceed count when changed the threshold type **How I verified it** Step1. Trigger exceed high threshold until the exceed count ran out. Step2. Change the threshold type to a different one and trigger exceed high threshold Step3. Check the exceed count reset to 0 and the exceed msg display ok. Signed-off-by: link_chiang <link_chiang@edge-core.com>
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2073 in repo Azure/sonic-swss |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…e changed (sonic-net#2073) Reset crm threshold exceed count when threshold type changed
…e changed (sonic-net#2073) Reset crm threshold exceed count when threshold type changed
What I did
Reset crm threshold exceed count when threshold type changed
Why I did it
The issue is that exceed msg not work when exceed count ran out by pervious threshold type.
Root cause is that doesn't reset the exceed count when changed the threshold type
How I verified it
Step1. Trigger exceed high threshold until the exceed count ran out.
Step2. Change the threshold type to a different one and trigger exceed high threshold
Step3. Check the exceed count reset to 0 and the exceed msg display ok.
Signed-off-by: link_chiang link_chiang@edge-core.com