[ACL]Avoid incrementing crm count when ACL rule create fails #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Apr 25, 2022
|
@prsunny could you please help to signoff? |
|
@dgsudharsan unrelated to this PR can you please check if we have such problem with other CRM counters? @volodymyrsamotiy FYI |
prsunny
approved these changes
Apr 25, 2022
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
5 tasks
judyjoseph
pushed a commit
that referenced
this pull request
May 2, 2022
* [ACL]Avoid incrementing crm count when ACL rule create fails
dgsudharsan
added
Cherry Pick Conflict_202012
and removed
Request for 202012 Branch
labels
dgsudharsan
added a commit
to dgsudharsan/sonic-swss
that referenced
this pull request
May 4, 2022
…et#2238) * [ACL]Avoid incrementing crm count when ACL rule create fails
prsunny
pushed a commit
that referenced
this pull request
May 5, 2022
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
…et#2238) * [ACL]Avoid incrementing crm count when ACL rule create fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Avoid increment CRM counter when ACL rule creation fails. In existing code there is no return statement after failure during ACL rule creation which results in CRM getting incremented. Since the ACL rule recreation is retried this counter increments in a loop.
Why I did it
Added return statement in case of a failure.
How I verified it
Existing UT should verify the changes
Details if related