Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: missing sonic-db-cli in docker-sonic-vs image #2357

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Fix: missing sonic-db-cli in docker-sonic-vs image #2357

merged 3 commits into from
Jul 7, 2022

Conversation

qiluo-msft
Copy link
Contributor

What I did
Fix: missing sonic-db-cli in docker-sonic-vs image

Why I did it

How I verified it

Details if related

@qiluo-msft qiluo-msft requested a review from prsunny as a code owner June 27, 2022 19:17
@liuh-80
Copy link
Contributor

liuh-80 commented Jun 28, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor

liuh-80 commented Jun 28, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor

liuh-80 commented Jun 29, 2022

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor

liuh-80 commented Jun 29, 2022

This PR blocked by some randomly failed UTs:

2022-06-29T05:12:36.1057643Z test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_creation FAILED [ 82%]
2022-06-29T05:12:36.2205230Z test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_add_ip_addrs FAILED [ 82%]
2022-06-29T05:12:36.2932181Z test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_appl_db_proc_seq FAILED [ 82%]
2022-06-29T05:12:36.3673395Z test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_admin_status_change FAILED [ 82%]
2022-06-29T05:12:36.4672083Z test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_remove_ip_addrs FAILED [ 83%]
2022-06-29T05:12:36.5390488Z test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_removal FAILED [ 83%]
2022-06-29T05:12:36.6127161Z test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_mtu FAILED [ 83%]
2022-06-29T05:12:36.7097591Z test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_nhg_accel FAILED [ 83%]
2022-06-29T05:12:36.7853144Z test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_oper_down_with_pending_neigh_route_tasks FAILED [ 83%]

2022-06-28T21:50:18.0131695Z _________________ TestSubPortIntf.test_sub_port_intf_creation __________________
2022-06-28T21:50:18.0131990Z
2022-06-28T21:50:18.0132733Z self = <test_sub_port_intf.TestSubPortIntf object at 0x7f29ce750550>
2022-06-28T21:50:18.0133202Z dvs = <conftest.DockerVirtualSwitch object at 0x7f29ceacdbb0>
2022-06-28T21:50:18.0133402Z
2022-06-28T21:50:18.0133771Z def test_sub_port_intf_creation(self, dvs):
2022-06-28T21:50:18.0135106Z > self.connect_dbs(dvs)
2022-06-28T21:50:18.0136417Z
2022-06-28T21:50:18.0136685Z test_sub_port_intf.py:585:
2022-06-28T21:50:18.0137137Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
2022-06-28T21:50:18.0137489Z test_sub_port_intf.py:86: in connect_dbs
2022-06-28T21:50:18.0137840Z self.default_vrf_oid = self.get_default_vrf_oid()
2022-06-28T21:50:18.0138213Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
2022-06-28T21:50:18.0138395Z
2022-06-28T21:50:18.0138720Z self = <test_sub_port_intf.TestSubPortIntf object at 0x7f29ce750550>
2022-06-28T21:50:18.0138949Z
2022-06-28T21:50:18.0139206Z def get_default_vrf_oid(self):
2022-06-28T21:50:18.0139657Z oids = self.get_oids(ASIC_VIRTUAL_ROUTER_TABLE)
2022-06-28T21:50:18.0140093Z > assert len(oids) == 1, "Wrong # of default vrfs: %d, expected #: 1." % (len(oids))
2022-06-28T21:50:18.0140508Z E AssertionError: Wrong # of default vrfs: 2, expected #: 1.
2022-06-28T21:50:18.0140833Z E assert 2 == 1
2022-06-28T21:50:18.0141416Z E -2
2022-06-28T21:50:18.0141662Z E +1

@liuh-80
Copy link
Contributor

liuh-80 commented Jun 29, 2022

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor

liuh-80 commented Jun 29, 2022

The cli issue been fixed by this PR: sonic-net/sonic-buildimage#11282
However, this PR still need complete and merge, after that, we can add the reverted PR back.

@liuh-80
Copy link
Contributor

liuh-80 commented Jun 29, 2022

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor

liuh-80 commented Jun 30, 2022

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor

liuh-80 commented Jun 30, 2022

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor

liuh-80 commented Jul 1, 2022

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor

liuh-80 commented Jul 4, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor

liuh-80 commented Jul 6, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit f565f7d into sonic-net:master Jul 7, 2022
@qiluo-msft qiluo-msft deleted the qiluo/fixcli branch July 7, 2022 23:18
@liuh-80 liuh-80 mentioned this pull request Aug 1, 2022
Closed
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
@qiluo-msft @preetham-singh
Fix: missing sonic-db-cli in docker-sonic-vs image (sonic-net#2357)
622c181 
*Fix: missing sonic-db-cli in docker-sonic-vs image
yxieca pushed a commit that referenced this pull request Aug 8, 2022
@qiluo-msft @yxieca
Fix: missing sonic-db-cli in docker-sonic-vs image (#2357)
450e9ec 
*Fix: missing sonic-db-cli in docker-sonic-vs image
liushilongbuaa pushed a commit to liushilongbuaa/sonic-swss that referenced this pull request Mar 20, 2023
@qiluo-msft @liushilongbuaa
Fix: missing sonic-db-cli in docker-sonic-vs image (sonic-net#2357)
ee29587 
*Fix: missing sonic-db-cli in docker-sonic-vs image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingwang-ms bingwang-ms bingwang-ms approved these changes

@yxieca yxieca yxieca approved these changes

@prsunny prsunny prsunny approved these changes

Assignees
No one assigned
Labels
Included in 202205 Branch Request for 202111 Branch Request for 202205 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qiluo-msft @liuh-80 @bingwang-ms @mssonicbld @prsunny @yxieca