sonic-swss: Key to check if entry in DB has a no-host-route entry. #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is a key called "no-host-route" in the DB. If there is one then treat that neighbor entry with SAI_NEIGHBOR_ENTRY_ATTR_NO_HOST_ROUTE. Justification for this change: required for Disaggregated networking support. Signed-off-by: Venkat Garigipati <venkatg@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check in NeighOrch::addVoqEncapIndex to validate if the there is a key called "no-host-route" in the DB. If there is one then treat that neighbor entry with SAI_NEIGHBOR_ENTRY_ATTR_NO_HOST_ROUTE.
Justification for this change: required for Disaggregated networking support.
What I did
Added a check in NeighOrch::addVoqEncapIndex to validate if the there is a key called "no-host-route" in the DB. If there is one then treat that neighbor entry with SAI_NEIGHBOR_ENTRY_ATTR_NO_HOST_ROUTE.
Why I did it
This is required for identifying if the route for remote neighbor needs to be differently for diaggregated network topology
How I verified it
What I did
Added a check in NeighOrch::addVoqEncapIndex to validate if the there is a key called "no-host-route" in the DB.
If there is one then treat that neighbor entry with SAI_NEIGHBOR_ENTRY_ATTR_NO_HOST_ROUTE
Why I did it
This is required for DSF static programming
How I verified it
},
"SYSTEM_NEIGH|Leaf2|Asic0|Ethernet256|77.0.0.1": {
"expireat": 1710262652.593254,
"ttl": -0.001,
"type": "hash",
"value": {
"encap_index": "1168",
"neigh": "f8:e5:7e:61:60:02"
}
},
"SYSTEM_NEIGH|Leaf3|Asic0|Ethernet256|78.0.0.1": {
"expireat": 1710262652.5932121,
"ttl": -0.001,
"type": "hash",
"value": {
"encap_index": "1216",
"neigh": "f8:e5:7e:61:60:03"
}
},
"SYSTEM_NEIGH|Leaf3|Asic0|Ethernet256|fc00:78::1": {
"expireat": 1710262652.5932224,
"ttl": -0.001,
"type": "hash",
"value": {
"encap_index": "1416",
"neigh": "f8:e5:7e:61:60:03"
}
}
}
root@Leaf3:/home/cisco# show chassis system-neighbors
System Port Interface Neighbor MAC Encap Index
Leaf0|Asic0|Ethernet256 75.0.0.1 f8:e5:7e:61:60:00 1072
Leaf1|Asic0|Ethernet256 76.0.0.1 f8:e5:7e:61:60:01 1120
Leaf2|Asic0|Ethernet256 77.0.0.1 f8:e5:7e:61:60:02 1168
Leaf3|Asic0|Ethernet256 78.0.0.1 f8:e5:7e:61:60:03 1216
Leaf3|Asic0|Ethernet256 fc00:78::1 f8:e5:7e:61:60:03 1416
logs:
syslog.20.gz:Mar 9 07:00:56.006094 Leaf3 INFO config_system_neigh.sh[3731]: Executing: sonic-db-cli CHASSIS_APP_DB hset "SYSTEM_NEIGH|Leaf0|Asic0|Ethernet256|75.0.0.1" "encap_index" "1072" "neigh" "f8:e5:7e:61:60:00" "no-host-route" "null"
syslog.20.gz:Mar 9 07:00:56.021578 Leaf3 INFO config_system_neigh.sh[3731]: Executing: sonic-db-cli CHASSIS_APP_DB hset "SYSTEM_NEIGH|Leaf1|Asic0|Ethernet256|76.0.0.1" "encap_index" "1120" "neigh" "f8:e5:7e:61:60:01" "no-host-route" "null"
syslog.20.gz:Mar 9 07:00:56.037819 Leaf3 INFO config_system_neigh.sh[3731]: Executing: sonic-db-cli CHASSIS_APP_DB hset "SYSTEM_NEIGH|Leaf2|Asic0|Ethernet256|77.0.0.1" "encap_index" "1168" "neigh" "f8:e5:7e:61:60:02" "no-host-route" "null"
syslog.20.gz:Mar 9 07:00:56.054838 Leaf3 INFO config_system_neigh.sh[3731]: Executing: sonic-db-cli CHASSIS_APP_DB hset "SYSTEM_NEIGH|Leaf3|Asic0|Ethernet256|78.0.0.1" "encap_index" "1216" "neigh" "f8:e5:7e:61:60:03" "no-host-route" "null"
syslog.20.gz:Mar 9 07:01:11.757862 Leaf3 NOTICE syncd#syncd#syncd: :- saiLoglevelNotify: Setting SAI loglevel SAI_LOG_LEVEL_NOTICE on SAI_API_NEIGHBOR
syslog.20.gz:Mar 9 07:45:56.063693 Leaf3 NOTICE syncd#syncd#syncd: :- saiLoglevelNotify: Setting SAI loglevel SAI_LOG_LEVEL_NOTICE on SAI_API_NEIGHBOR
syslog.20.gz:Mar 9 07:57:58.089596 Leaf3 NOTICE syncd#syncd#syncd: :- saiLoglevelNotify: Setting SAI loglevel SAI_LOG_LEVEL_NOTICE on SAI_API_NEIGHBOR
Details if related