Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests]: Add extra options to the test runner #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pavel-shirshov
Copy link
Contributor

What I did
Add two extra options to the test runner:

  1. Change orchagent log level
  2. Save logs after each test to a host machine

Why I did it
It allows us to get reason why tests fails faster

How I verified it
Run it manually

Details if related

yield dvs

if get_logs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is getting all logs. Usually, when you done with an appdb input, you just want to get new logs. I think we need to provide api to do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "new logs"? Do you mean we want to see only logs which were created during a test?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean new log entries generated after you run certain commands.

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…upto 5 times for swss docker warm upgrade. (sonic-net#420)

Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
@prsunny prsunny self-requested a review as a code owner September 2, 2022 23:17
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
* Add support for fdb_event MOVE and check fdb event oids

* bring back ntf_queue constructor

* Log also entire fdb_entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants