[intfsorch]:add support to change rif mac address

[shine4chen]

What I did
add support to change rif mac address

Why I did it
some apps such as mclag or vrrp need to change rif mac address

How I verified it
test it on nephos lab

Details if related

[prsunny]

"mac_addr" is not a field currently in the INTF_TABLE/INTERFACE_TABLE. This needs to be defined in the schema and also require corresponding change in interface manager

[lguohan]

need virtual switch test.

[lguohan]

@prsunny , I assume this can only be on rif without ip address. We can not set mac address for interface entry with IP address since we only create one rif for all ip addresses on that rif?

[jianjundong]

@prsunny , I assume this can only be on rif without ip address. We can not set mac address for interface entry with IP address since we only create one rif for all ip addresses on that rif?

In mclag, the ip address of mclag enabled portchannel of two peers must be the same, thus the mac address of rifs also must be the same.

[jianjundong]

"mac_addr" is not a field currently in the INTF_TABLE/INTERFACE_TABLE. This needs to be defined in the schema and also require corresponding change in interface manager

'mac_addr' is set as a field of INTF_TABLE in APP_DB currently. It is set by iccpd through mclagsyncd. This field may also be set as a field of INTERFACE_TABLE in CFG_DB and processed by intfmgrd? Thanks.

[shine4chen]

need virtual switch test.

sure, we will add it soon

[shine4chen]

need virtual switch test.

@lguohan Can you give us example or URL how to connect virtual switch test to specific PR

[shine4chen]

@lguohan even for the interface associated with the ip address we still can/need to change its src-mac.

[shine4chen]

@prsunny Per our discussion on VRF, src-mac attribute should be put on {INTERFACE:Ethernetx} entry. I suggest we merge this PR to VRF code. How about your opinion?

[lguohan]

@shine4chen , thanks for adding vs test, but the added two tests are failing, can you investigate the failure.

[stcheng]

please check the comments.

one more question, will you support remove the source MAC address once it is set?

[leoli-nps]

The vstest has been updated, please review. Thanks!

[shine4chen]

@stcheng @prsunny we have refined code according to your suggestion. Pls help to review it. Thanks.

[prsunny]

@prsunny Per our discussion on VRF, src-mac attribute should be put on {INTERFACE:Ethernetx} entry. I suggest we merge this PR to VRF code. How about your opinion?

@shine4chen , yes I agree. I think you've made the changes based on this assumption currently correct?. If so, the change must be in doIntfGeneralTask and not in doIntfAddrTask in intfmgr.cpp. Can you please check?

[shine4chen]

@prsunny Per our discussion on VRF, src-mac attribute should be put on {INTERFACE:Ethernetx} entry. I suggest we merge this PR to VRF code. How about your opinion?

@shine4chen , yes I agree. I think you've made the changes based on this assumption currently correct?. If so, the change must be in doIntfGeneralTask and not in doIntfAddrTask in intfmgr.cpp. Can you please check?
@prsunny yes, We will move the change to doIntfGeneralTask function.