Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dot1p to tc mapping support #871

Merged
merged 15 commits into from
Sep 6, 2019
Merged

Add dot1p to tc mapping support #871

merged 15 commits into from
Sep 6, 2019

Conversation

wendani
Copy link
Contributor

@wendani wendani commented May 2, 2019 •
edited
Loading

What I did

Why I did it

How I verified it
Manual test on brcm with the following configuration add-on:

"DOT1P_TO_TC_MAP": {
    "AZURE": {
        "1": "6",
        "0": "0",
        "3": "3",
        "2": "5",
        "5": "2",
        "4": "4",
        "7": "0",
        "6": "1"
    }
},
"PORT_QOS_MAP": {
    "Ethernet4,Ethernet8,Ethernet12,Ethernet16,Ethernet20,Ethernet24,Ethernet28,Ethernet32,Ethernet36,Ethernet40,Ethernet44,Ethernet48,Ethernet52,Ethernet56,Ethernet60,Ethernet64,Ethernet68,Ethernet72,Ethernet76,Ethernet80,Ethernet84,Ethernet88,Ethernet92,Ethernet96,Ethernet112,Ethernet116,Ethernet120,Ethernet124": {
        "tc_to_pg_map": "[TC_TO_PRIORITY_GROUP_MAP|AZURE]",
        "tc_to_queue_map": "[TC_TO_QUEUE_MAP|AZURE]",
        "dot1p_to_tc_map": "[DOT1P_TO_TC_MAP|AZURE]",
        "pfc_enable": "3,4",
        "pfc_to_queue_map": "[MAP_PFC_PRIORITY_TO_QUEUE|AZURE]"
    }
},
  1. mem diag dump is correct
  2. dot1p to pg mapping is correct
  3. dot1p to queue mapping is correct
  4. dot1p 3 triggers PFC3
  5. dot1p 4 triggers PFC4

vs test commands:

sonic-buildimage/src/sonic-swss/tests$ sudo pytest test_qos_map.py::TestDot1p::test_dot1p_cfg --dvsname=vs

sonic-buildimage/src/sonic-swss/tests$ sudo pytest test_qos_map.py::TestDot1p::test_port_dot1p --dvsname=vs

Details if related
Depend on:
schema update: sonic-net/sonic-swss-common#274

wendani added 3 commits May 2, 2019 01:59
@wendani
Initial implementation of dot1p to tc mapping
7e74fcd 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Fix compile error
8d3c1de 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Listen to DOT1P_TO_TC_MAP table
85bfb89 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani wendani requested review from qiluo-msft and lguohan May 2, 2019 02:08
@lguohan
Copy link
Contributor

lguohan commented Jun 4, 2019

missing vs test.

lguohan
lguohan reviewed Jun 4, 2019
View reviewed changes
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing vs test.

lguohan
lguohan requested changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing vstest

@wendani
Follow variable naming convention
d7610bd 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani wendani requested a review from lguohan August 3, 2019 04:16
@wendani
Copy link
Contributor Author

wendani commented Aug 3, 2019

Added dot1p profile test and dot1p profile applying to ports test
#871 (review)

@wendani
Copy link
Contributor Author

wendani commented Aug 6, 2019

retest this please

@wendani wendani requested a review from stcheng August 6, 2019 18:35
@lguohan
Copy link
Contributor

lguohan commented Aug 8, 2019

retest this please

5 similar comments
@wendani
Copy link
Contributor Author

wendani commented Aug 9, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Aug 9, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Aug 9, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Aug 10, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Aug 12, 2019

retest this please

@lguohan lguohan merged commit 5841e06 into sonic-net:master Sep 6, 2019
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@akokhan
Fixed fast-reboot for BFN platform (sonic-net#871)
af42b55 
Signed-off-by: Andriy Kokhan <akokhan@barefootnetworks.com>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@kcudnik
[tests] Fix error code check (sonic-net#871)
6921d99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

@stcheng stcheng Awaiting requested review from stcheng

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wendani @lguohan @stcheng