[sfpshow]: display eeprom data in table format

[mudsut4ke]

- What I did

• Fixes: [show]: add transceiver info  #939
• Add option to display eeprom data in table format to sfpshow

- How I did it

• Modify sfpshow script
• Add table display option to show script

- How to verify it

• Run command show interfaces transceiver eeprom -t
• Run command show interfaces transceiver eeprom -d -t
• sfpshow_test.log
• sfpshow_pytest.log

- Previous command output (if the output of a command-line utility has changed)

admin@sonic:~$ show interfaces transceiver eeprom --help
Usage: show interfaces transceiver eeprom [OPTIONS] [INTERFACENAME]

  Show interface transceiver EEPROM information

Options:
  -d, --dom       Also display Digital Optical Monitoring (DOM) data
  --verbose       Enable verbose output
  -?, -h, --help  Show this message and exit.
admin@sonic:~$ 

- New command output (if the output of a command-line utility has changed)

admin@sonic:~$ show interfaces transceiver eeprom --help
Usage: show interfaces transceiver eeprom [OPTIONS] [INTERFACENAME]

  Show interface transceiver EEPROM information

Options:
  -d, --dom       Also display Digital Optical Monitoring (DOM) data
  -t, --table     Display SFP EEPROM data in table format
  --verbose       Enable verbose output
  -?, -h, --help  Show this message and exit.
admin@sonic:~$ 
admin@sonic:~$ show interfaces transceiver eeprom -t Ethernet8
Interface    Identifier       Connector    Vendor Name    Model Name          Serial Number    Nominal Bit Rate(100Mbs)
-----------  ---------------  -----------  -------------  ----------------  ---------------  --------------------------
Ethernet8    QSFP28 or later  LC           ColorChip ltd  C100QSFPCWDM400B         18130616                         255
admin@sonic:~$ show interfaces transceiver eeprom -t -d Ethernet8
Interface    Lane Number    Temp(C)                      Voltage(V)                   Current(mA)                  Tx Power(dBm)                      Rx Power(dBm)
-----------  -------------  ---------------------------  ---------------------------  ---------------------------  ---------------------------------  ----------------------------------
Ethernet8    Lane 1         32.1055 [low=0.0,high=58.0]  3.3769 [low=25.0,high=75.0]  56.762 [low=25.0,high=75.0]  0.4961 [low=-7.0006,high=2.2999]   0.4961 [low=-13.6957,high=2.2999]
             Lane 2         32.1055 [low=0.0,high=58.0]  3.3769 [low=25.0,high=75.0]  55.416 [low=25.0,high=75.0]  0.3782 [low=-7.0006,high=2.2999]   0.3782 [low=-13.6957,high=2.2999]
             Lane 3         32.1055 [low=0.0,high=58.0]  3.3769 [low=25.0,high=75.0]  41.614 [low=25.0,high=75.0]  0.5918 [low=-7.0006,high=2.2999]   0.5918 [low=-13.6957,high=2.2999]
             Lane 4         32.1055 [low=0.0,high=58.0]  3.3769 [low=25.0,high=75.0]  41.648 [low=25.0,high=75.0]  -0.1909 [low=-7.0006,high=2.2999]  -0.1909 [low=-13.6957,high=2.2999]
admin@sonic:~$ 

Signed-off-by: Wirut Getbamrung [wgetbumr@celestica.com]

[lguohan]

retest this please

[jleveque]

Retest this please

[lguohan]

can you resolve the conflict?

[lguohan]

can you also please add the unit test?

[mudsut4ke]

@lguohan

can you resolve the conflict?

• resolved

can you also please add the unit test?

• Do you mean that I should add another function to this following script, correct ?
  https://github.com/Azure/sonic-utilities/blob/master/tests/sfp_test.py

[mudsut4ke]

can you also please add the unit test?

@lguohan , added in 72f0f60

[jleveque]

LGTM. @keboliu to review, as well.

[keboliu]

I have a concern about the way you handle the temperature, it's not some sensor that monitored per lane, here you added it to each lane, it's kind of misleading. The same comment goes to the voltage.