-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display large number of FDB entries fast from state_db and appl_db #1273
base: master
Are you sure you want to change the base?
Conversation
retest this please |
retest this please |
retest this please |
Seem it is not the code of this pull request to cause the error result. Test Result (失败) 11:55:27 /usr/local/lib/python3.8/dist-packages/six.py:702: |
retest this please |
1 similar comment
retest this please |
@JiangboHe , could you please add unit test to cover this? |
@prsunny OK, I will add some unit test later. |
seems like the fix for 201911 was closed and the intention was first to take to master and then cherry pick it. |
@liat-grozovik I try to provide the UT next month. |
@JiangboHe kindly reminder. we would like this fix to be in master and 202012 . will you be able to provide so it can be merged? |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@liat-grozovik Sorry to reply late. There was some building problem in my enviroment. I am trying to fix it and finish the test case. Thanks |
@JiangboHe where do we stands with this PR? |
@liat-grozovik There is some problem with my network in master branch building. I am trying to fix it. |
I noticed some issues with master in the last day as well. It might be general one
202012 is working
201911 I think also not working but not sure in 100%
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: JiangboHe ***@***.***>
Sent: Friday, March 19, 2021 10:42:40 AM
To: Azure/sonic-utilities ***@***.***>
Cc: Liat Grozovik ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/sonic-utilities] Display large number of FDB entries fast from state_db and appl_db (#1273)
@liat-grozovik<https://github.com/liat-grozovik> There is some problem with my network in master branch building. I am trying to fix it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1273 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABAYNFQVB3PCFEPTPYODTEMFABANCNFSM4UCABE6A>.
|
@JiangboHe could you please fix conflicts and then we can re run tests to approve the fix? |
@prsunny can you please review the failure and update the status |
@JiangboHe can you update with the UT? |
@JiangboHe Can you please provide an update? |
@zhangyanzhao Let's triage this issue. |
This is a copy of pull request #968, we found and fixed it in 201911 branch. It need also be merged to master.
- What I did
An option is provided for showing large number of fdb tables faster.
The time cost to display change from 50 seconds to 2 seconds for 8000 fdb tables or 20 seconds to 1 seconds for 5000 fdb tables.
- How I did it
The key search and judge of fdb tables in asic table is too complex. It will cost 20 seconds for 5000 fdb tables or 50 seconds for 8000 fdb tables. It is not good for users or script running. The option is to show fdb tables from state_db.
- How to verify it
Learn thounds of fdb tables and show them with fdbshow
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)