[config] CLI command configure interface ip doesn't check correctness of inputs #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
|
@d-dashkov - Are you going to handle this PR ? I see that it got a conflict. |
|
Sorry, I will resolve conflicts within a couple of days |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dgsudharsan could you please review this PR? |
prsunny
reviewed
Oct 6, 2021
dgsudharsan
suggested changes
Oct 7, 2021
Signed-off-by: Mykola Horb <mykola_horb@jabil.com>
dgsudharsan
previously approved these changes
Oct 9, 2021
prsunny
previously approved these changes
Oct 12, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@d-dashkov Can you please check the pipeline failures? |
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
|
@dgsudharsan, I have fixed sonic-utilities tests and merge conflicts, but there are errors in pipeline which are not related to my changes, and it is about warm-reboot |
dgsudharsan
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Before writing the settings to the database, check the correctness of the entries.
If you try to bind the ip of a non-existent entry, show an error.
fixes sonic-net/sonic-buildimage#6358
- How I did it
Added functions that check if an entry from an argument exists in the database.
- How to verify it
Try to configure ip to non-existent entry(Ethernet, Vlan, PortChannel, Loopback):
$ config interface ip add Ethernet0.5 10.0.0.1/24
$ config interface ip add Vlan4095 10.0.0.1/24
- New command output (if the output of a command-line utility has changed)
Error: 'interface_name' is not valid. Valid names [Ethernet/PortChannel/Vlan/Loopback]