[dhcp_relay] Update CLI reference document and add a new API for ip address type #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new API on utilities_common to get IP type Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
This was referenced Jul 18, 2021
Merged
|
@tahmed-dev can you please review this PR? |
|
Hi @tahmed-dev - could you please review and approve asap, this is needed in 202106 release |
tahmed-dev
reviewed
Aug 3, 2021
| @@ -200,6 +201,17 @@ def is_ipaddress(val): | |||
| return False | |||
| return True | |||
|
|
|||
| def ipaddress_type(val): | |||
There was a problem hiding this comment.
is ipaddress_type used anywhere?
There was a problem hiding this comment.
Yes, on the other PR for the CLI:
sonic-net/sonic-buildimage#8211
This is why this PR is a dependency for the other.
|
@tahmed-dev kindly reminder to review following the above reply |
|
@tahmed-dev kindly remider |
tahmed-dev
approved these changes
Aug 16, 2021
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Aug 25, 2021
…8211) #### Why I did it - Adapt config/show CLI commands to support DHCPv6 relay - Support multiple dhcp servers assignment in one command - Fix IP validation - Adapt UT and add new UT cases #### How I did it - Modify config/show dhcp relay files - Modify config/show UT files #### How to verify it This PR has a dependency on PR sonic-net/sonic-utilities#1717 Build an image with the dependent PR and this PR Use config/show DHCPv6 relay commands.
judyjoseph
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Aug 25, 2021
…8211) #### Why I did it - Adapt config/show CLI commands to support DHCPv6 relay - Support multiple dhcp servers assignment in one command - Fix IP validation - Adapt UT and add new UT cases #### How I did it - Modify config/show dhcp relay files - Modify config/show UT files #### How to verify it This PR has a dependency on PR sonic-net/sonic-utilities#1717 Build an image with the dependent PR and this PR Use config/show DHCPv6 relay commands.
judyjoseph
pushed a commit
that referenced
this pull request
Aug 26, 2021
…ddress type (#1717) #### What I did Update CLI reference document following PR : sonic-net/sonic-buildimage#8211 Add a new API on utilities_common to get IP type. #### How I did it - Update doc/Command-Reference.md with new DHCP CLI. - Add ipaddress_type API to utilities_common/cli.py #### How to verify it - Build an image with PR sonic-net/sonic-buildimage#8211 and this PR. - Run DHCP CLI commands
shlomibitton
deleted the
shlomi_dhcpv6_relay_update_cli_ref_and_ip_type_api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
What I did
Update CLI reference document following PR : sonic-net/sonic-buildimage#8211
Add a new API on utilities_common to get IP type.
How I did it
How to verify it