Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019]Load MIRROR_DSCP config files at load_minigraph #1849

Open
wants to merge 4 commits into
base: 201911
Choose a base branch
from

Conversation

bingwang-ms
Copy link
Contributor

What I did

This PR is from #1838. Since it's not a clean cherry-pick, I opened this PR for 201911 branch.
Compared with #1838 , diffs include

  1. Use run_command instead of clicommon.run_command
  2. Implement new UT for 201911 branch

How I did it

Please refer #1838

How to verify it

  1. Verified by UT
  2. Verified on Arista-7260, running 20191130.76

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

bingwang-ms and others added 4 commits September 30, 2021 02:42
Signed-off-by: bingwang <bingwang@microsoft.com>
Signed-off-by: bingwang <bingwang@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Sep 30, 2021

This pull request introduces 4 alerts when merging 47f09a5 into 3b78032 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Module is imported more than once
  • 1 for Unused local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant