Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TACACS+] Add config command for AAA authorization and accounting. #1889

Merged

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Oct 20, 2021

This pull request add config command for AAA authorization & accounting.

Why I did it

Support TACACS per-command authorization & accounting.

How I did it

Change AAA config command to support authorization & accounting.
Change show AAA command to support authorization & accounting.
Add UT to cover changed code.

How to verify it

1. Build following project and pass all UTs:
    make target/python-wheels/sonic_utilities-1.2-py3-none-any.whl
2. Test new command manually.

Which release branch to backport (provide reason below if selected)

N/A

Description for the changelog

Add config command for AAA authorization & accounting.

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request introduces 7 alerts when merging d868e6a into e600e1c - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a call

@liuh-80
Copy link
Contributor Author

liuh-80 commented Oct 21, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80 liuh-80 changed the title Add new command for AAA authorization and accounting. [TACACS+] Add config command for AAA authorization and accounting. Oct 21, 2021
config/aaa.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Oct 22, 2021

This pull request introduces 1 alert when merging 7695442 into 9017d99 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@liuh-80
Copy link
Contributor Author

liuh-80 commented Oct 23, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor Author

liuh-80 commented Oct 25, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor Author

liuh-80 commented Oct 25, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor Author

liuh-80 commented Oct 26, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80 liuh-80 marked this pull request as ready for review October 28, 2021 06:56
@liuh-80
Copy link
Contributor Author

liuh-80 commented Oct 29, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

config/aaa.py Outdated Show resolved Hide resolved
@liuh-80 liuh-80 merged commit 63a5257 into sonic-net:master Nov 9, 2021
@liuh-80 liuh-80 deleted the dev/liuh/tacacs_authorization_config branch July 4, 2023 04:26
liuh-80 added a commit to liuh-80/sonic-utilities that referenced this pull request Jul 4, 2023
…onic-net#1889)

This pull request add config command for AAA authorization & accounting.

    Support TACACS per-command authorization & accounting.

    Change AAA config command to support authorization & accounting.
    Change show AAA command to support authorization & accounting.
    Add UT to cover changed code.

    1. Build following project and pass all UTs:
        make target/python-wheels/sonic_utilities-1.2-py3-none-any.whl
    2. Test new command manually.

    N/A

    Add config command for AAA authorization & accounting.
liuh-80 added a commit that referenced this pull request Jul 10, 2023
…nting. (#1889) (#2891)

* [TACACS+] Add config command for AAA authorization and accounting. (#1889)

This pull request add config command for AAA authorization & accounting.

    Support TACACS per-command authorization & accounting.

    Change AAA config command to support authorization & accounting.
    Change show AAA command to support authorization & accounting.
    Add UT to cover changed code.

    1. Build following project and pass all UTs:
        make target/python-wheels/sonic_utilities-1.2-py3-none-any.whl
    2. Test new command manually.

    N/A

    Add config command for AAA authorization & accounting.

* Remove radius UT

* Remove UT because depends code change not in 202012

---------

Co-authored-by: Qi Luo <qiluo-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants