[GCU] Disallowing DeleteInsteadOfReplaceMoveExtender from generating delete whole config move #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delete whole config move
ghooo
force-pushed
the
dev/mghoneim/delete_whole
branch
from
b0a00bb
to
bf0d496
Compare
ghooo
commented
Jan 12, 2022
| @@ -2811,5 +2811,88 @@ | |||
| } | |||
| ] | |||
| ] | |||
| }, | |||
| "ADDING_LOOPBACK0_VRF_NAME__DELETES_LOOPBACK0_AND_IPS_DOES_NOT_AFFECT_OTHER_TABLES": { | |||
There was a problem hiding this comment.
Test case related to issue #2000 (comment)
renukamanavalan
approved these changes
Jan 13, 2022
qiluo-msft
approved these changes
Jan 13, 2022
|
Verified locally. Vrf change can pass now. |
4 tasks
wen587
approved these changes
Jan 13, 2022
| @@ -2811,5 +2811,88 @@ | |||
| } | |||
| ] | |||
| ] | |||
| }, | |||
| "ADDING_LOOPBACK0_VRF_NAME__DELETES_LOOPBACK0_AND_IPS_DOES_NOT_AFFECT_OTHER_TABLES": { | |||
judyjoseph
pushed a commit
that referenced
this pull request
Jan 17, 2022
…delete whole config move (#2006) #### What I did Not generating delete whole config move because it is not allowed by JsonPatch library and it is not possible for ConfigDb to be equal to NULL. This solves the first problem in issue #2000 (comment) #### How I did it - Verified UpperLevelMoveExtender does not generate delete whole config move - Modified DeleteInsteadOfReplaceMoveExtender to not generate delete whole config move - DeleteRefsMoveExtender cannot generate delete whole config move, because it deletes the referrer leafs #### How to verify it unit-test #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Not generating delete whole config move because it is not allowed by JsonPatch library and it is not possible for ConfigDb to be equal to NULL.
This solves the first problem in issue #2000 (comment)
How I did it
How to verify it
unit-test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)