[generic-config-updater] Add caclrule validator #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Mar 16, 2022
qiluo-msft
reviewed
Mar 16, 2022
qiluo-msft
reviewed
Mar 16, 2022
| if (old_aclrule.get(key, {}) != upd_aclrule.get(key, {})): | ||
| # caclmgrd will update in 0.5 sec when configuration stops, | ||
| # we sleep 1 sec to make sure it does update. | ||
| rc = os.system("sleep 1s") |
There was a problem hiding this comment.
This is to check the test cmds https://github.com/Azure/sonic-utilities/blob/13f88c1aad4c6a5293fef978b7affb95335d1f04/tests/generic_config_updater/service_validator_test.py#L106 also avoid conflict use with
https://github.com/Azure/sonic-utilities/blob/13f88c1aad4c6a5293fef978b7affb95335d1f04/generic_config_updater/services_validator.py#L37
qiluo-msft
reviewed
Mar 16, 2022
qiluo-msft
approved these changes
Mar 18, 2022
|
@renukamanavalan could you help review? |
@prsunny, can you please help? |
prsunny
approved these changes
Mar 19, 2022
prsunny
reviewed
Mar 19, 2022
| if (old_aclrule.get(key, {}) != upd_aclrule.get(key, {})): | ||
| # caclmgrd will update in 0.5 sec when configuration stops, | ||
| # we sleep 1 sec to make sure it does update. | ||
| time.sleep(1) |
There was a problem hiding this comment.
IMO, this is a blind sleep. If caclmgrd is changed in future to wait 1sec, we may have to revisit here. I don't have a better suggestion though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the json patch could be gathered in some way, it should fix nightly random failure issue.
What I did
When gcu make change to control plane ACL_RULE, the iptables doen't change immediately. There is a delay because caclmgr will update in 0.5 sec if no more update being made to config. So I add a caclrule validator to make sure the iptable is updated.
How I did it
When caclrule is being changed, add a 1sec sleep to make sure caclmgr does update.
How to verify it
Run sonic-utilities unit test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)