Fix sonic-installer and 'show version' command crash when database docker not running issue. #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code change in this PR will validate and pass E2E test with this: sonic-net/sonic-buildimage#10909 |
qiluo-msft
reviewed
May 26, 2022
6 tasks
…y_global_variable
|
Test with build image failed, not caused by change in this PR, seems fixed in master branch, will merge latest code and test again. |
qiluo-msft
approved these changes
May 27, 2022
|
Could you update PR description?
|
liuh-80
changed the title
|
@qiluo-msft @liuh-80 Is there going to be a UT covering this fix ? |
1 similar comment
|
@qiluo-msft @liuh-80 Is there going to be a UT covering this fix ? |
|
@liuh-80 Please add unit test for this fix. |
Here is UT PR: sonic-net/sonic-mgmt#5722 |
6 tasks
This was referenced Jun 9, 2022
This was referenced Jun 28, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 4, 2022
#### What I did Fix pfcwd connect DB with exception issue: sonic-net/sonic-buildimage#11269 pfcwd implicit depends on InterfaceAliasConverter() to initialize DB config, however following PR change InterfaceAliasConverter() behavior to lazy initialize, then pfcwd failed when try connect to DB without initialize DB config: #2183 #### How I did it Load DB config in pfcwd. #### How to verify it Pass all UT.
|
@liuh-80 @qiluo-msft Could you please cherry pick this PR to 2205? |
yxieca
pushed a commit
that referenced
this pull request
Sep 8, 2022
…cker not running issue. (#2183) Fix sonic-installer and 'show version' command crash when database docker not running issue. #### Description Global variable utilies_common.cli.iface_alias_converter will connect to config DB when initialize itself. If database docker not running, the initialize code will crash. To fix this issue, change the variable to lazy initialize variable with lazy_object_proxy. #### Motivation and Context Fix this issue: sonic-net/sonic-buildimage#10434 #### How Has This Been Tested? Pass all UT and sonic-buildimage E2E test. #### Additional Information (Optional)
gechiang
pushed a commit
to gechiang/sonic-utilities
that referenced
this pull request
Sep 14, 2022
#### What I did Fix pfcwd connect DB with exception issue: sonic-net/sonic-buildimage#11269 pfcwd implicit depends on InterfaceAliasConverter() to initialize DB config, however following PR change InterfaceAliasConverter() behavior to lazy initialize, then pfcwd failed when try connect to DB without initialize DB config: sonic-net#2183 #### How I did it Load DB config in pfcwd. #### How to verify it Pass all UT.
gechiang
added a commit
that referenced
this pull request
Sep 15, 2022
#### What I did Fix pfcwd connect DB with exception issue: sonic-net/sonic-buildimage#11269 pfcwd implicit depends on InterfaceAliasConverter() to initialize DB config, however following PR change InterfaceAliasConverter() behavior to lazy initialize, then pfcwd failed when try connect to DB without initialize DB config: #2183 #### How I did it Load DB config in pfcwd. #### How to verify it Pass all UT. Co-authored-by: Hua Liu <58683130+liuh-80@users.noreply.github.com>
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
#### What I did Fix pfcwd connect DB with exception issue: sonic-net/sonic-buildimage#11269 pfcwd implicit depends on InterfaceAliasConverter() to initialize DB config, however following PR change InterfaceAliasConverter() behavior to lazy initialize, then pfcwd failed when try connect to DB without initialize DB config: sonic-net/sonic-utilities#2183 #### How I did it Load DB config in pfcwd. #### How to verify it Pass all UT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sonic-installer and 'show version' command crash when database docker not running issue.
Description
Motivation and Context
Fix this issue: sonic-net/sonic-buildimage#10434
How Has This Been Tested?
Additional Information (Optional)