[GCU] Moving UniqueLanes from only validating moves, to be a supplemental YANG validator #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Jun 28, 2022
qiluo-msft
reviewed
Jun 28, 2022
qiluo-msft
reviewed
Jun 28, 2022
ghooo
commented
Jun 28, 2022
qiluo-msft
approved these changes
Jun 28, 2022
yxieca
pushed a commit
that referenced
this pull request
Jun 30, 2022
…ntal YANG validator (#2234) #### What I did - Added a new supplemental YANG validator to validate UniqueLanes in `validate_config_db_config` - Removed UniqueLanesMoveValidator as the lanes validation will be taken care of by FullConfigMoveValidator which uses `validate_config_db_config` The benefit of this is at the beginning of `apply-patch` we make a call to `validate_config_db_config` to check if the given patch is valid or not ([code](https://github.com/Azure/sonic-utilities/blob/e6e4f8ceb9a59fb7b3767a65ffc4f017d0807832/generic_config_updater/patch_sorter.py#L1522)). Now we will fail early, instead of going for the move generation and not being able to generate a moves. #### How I did it Check code. #### How to verify it Added unit-tests. #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
isabelmsft
reviewed
Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
validate_config_db_configvalidate_config_db_configThe benefit of this is at the beginning of
apply-patchwe make a call tovalidate_config_db_configto check if the given patch is valid or not (code). Now we will fail early, instead of going for the move generation and not being able to generate a moves.How I did it
Check code.
How to verify it
Added unit-tests.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)