[Kdump] Fix the error message when trying to enable kdump if kdump was already enabled #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… already enabled If kdump is already enabled and a command is executed to enable kdump again, the following message will be occurred in syslog. INFO hostcfgd[6930]: Error Unable to unload Kdump the kernel '%s' [] INFO hostcfgd[6930]: kdump is already enabled ERR hostcfgd: sonic-kdump-config --enable - failed: return code - 1, output:#012None This commit modified the logic in kdump_enable() which will return directly when there does not have to apply any change after comparing to the expected configuration and the current operational mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The following error message will be shown in the syslog by doing "sudo config kdump enable" when kdump was already enabled.
INFO hostcfgd[6930]: Error Unable to unload Kdump the kernel '%s' []INFO hostcfgd[6930]: kdump is already enabledERR hostcfgd: sonic-kdump-config --enable - failed: return code - 1, output:#012NoneThe root cause is that there has some logical error in 'kdump_enable()' function
How I did it
Modified the logic in kdump_enable() which will return directly
when there does not need to apply any change after comparing to the expected
configuration and the current operational mode.
How to verify it
Previous command output (if the output of a command-line utility has changed)
No command-line changed
New command output (if the output of a command-line utility has changed)
No command-line changed