Add a stub for arp-helper #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Jul 10, 2018
lguohan
reviewed
Jul 10, 2018
setup.py
Outdated
| @@ -37,6 +37,7 @@ def get_test_suite(): | |||
| }, | |||
| scripts=[ | |||
| 'scripts/aclshow', | |||
| 'scripts/arp-helper-start', | |||
There was a problem hiding this comment.
rename to arp-helper is better, we could have arp-helper start ip address or arp-helper stop later.
lguohan
requested changes
Jul 10, 2018
lguohan
approved these changes
Jul 11, 2018
lguohan
reviewed
Jul 11, 2018
|
|
||
| def main(): | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('arp_helper_ip', help="ip address of an ARP Helper") |
There was a problem hiding this comment.
for completeness, we should have --start and --stop to start of stop arphelper.
jleveque
suggested changes
Jul 13, 2018
| return | ||
|
|
||
| if __name__ == '__main__': | ||
| main() |
There was a problem hiding this comment.
Add newline at end of file.
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
…hen mux toggle is inprogress (sonic-net#280) In this PR, there is a support for adding a mux_toggle_status variable inside the base class for mux_cable. Using this variable the Derived classes for mux_cable can check this and return in case of a mux_toggle_status is in progress. From the higher layer this allows ycabled to synchronize the calls and not let mux_cable toggle to go in conjunction with some of the Telemetry calls. Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com Description Motivation and Context To get the toggle time to a minimum/ not allow i2c to transactions on the cable to collide with each other How Has This Been Tested? Ran the changes on 7050cx3 arista testbed Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added a stub for arp-helper-start script
- How I did it
use my editor
- How to verify it
Build an image with this script and then run the script
'arp-helper-start 10.0.0.1'
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
Currently the output would be OK
-->