Exposing config-check logic to CLI #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm simply extending the new config verification logic to our current CLI commands so that a config-check is implicitly done whenever user executes 'config load/reload' commands. See some examples below...
As part of this PR i'm also adding a new CLI command to allow users to explicitly validate their json-file configuration.
<-- Running 'config load' with invalid configuration:
admin@lnos-x1-a-csw02:~$ sudo config load ~/config_db.json
Reload all config? [y/N]: y
Running command: sonic-cfggen -j /home/admin/config_db.json --check-json
DEVICE_NEIGHBOR port Ethernet5 not found in PORT table.
Invalid configuration detected. No configuration changes processed. Exiting...
<-- Running 'config reload' with invalid configuration:
admin@lnos-x1-a-csw02:~$ sudo config reload ~/config_db.json
Clear current and reload all config? [y/N]: y
Running command: sonic-cfggen -j /home/admin/config_db.json --check-json
DEVICE_NEIGHBOR port Ethernet5 not found in PORT table.
Invalid configuration detected. No configuration changes processed. Exiting...
<-- Running 'config check' with invalid configuration:
admin@lnos-x1-a-csw02:~$ sudo config check ~/config_db.json
Running command: sonic-cfggen -j /home/admin/config_db.json --check-json
DEVICE_NEIGHBOR port Ethernet5 not found in PORT table.
Invalid configuration detected. No configuration changes processed. Exiting...
<-- Running 'config check' with valid configuration:
admin@lnos-x1-a-csw02:~$ sudo config check /etc/sonic/config_db.json
Running command: sonic-cfggen -j /etc/sonic/config_db.json --check-json
Valid configuration found in /etc/sonic/config_db.json file
Signed-off-by: Rodny Molina <rmolina@linkedin.com>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
When insert trasnceiver which is not QSFP-DD, "sfputil show error-status -hw" would fail
error:
File "/usr/local/lib/python3.7/dist-packages/sonic_platform_base/sonic_xcvr/sfp_optoe_base.py", line 211, in get_error_description
return api.get_error_description() if api is not None else None
AttributeError: 'Sff8636Api' object has no attribute 'get_error_description'
Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm simply extending the new config verification logic to our current CLI commands so that a config-check is implicitly done whenever user executes 'config load/reload' commands. See some examples below...
As part of this PR i'm also adding a new CLI command to allow users to explicitly validate their json-file configuration.
<-- Running 'config load' with invalid configuration:
<-- Running 'config reload' with invalid configuration:
<-- Running 'config check' with invalid configuration:
<-- Running 'config check' with valid configuration:
Signed-off-by: Rodny Molina rmolina@linkedin.com