Add sonic-clear logging command #3151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mati <mati@marvell.com>
Signed-off-by: mati <mati@marvell.com>
|
@mihirpat1 would you be able to review? |
amazor
approved these changes
Feb 6, 2024
mihirpat1
reviewed
Feb 9, 2024
| @cli.command() | ||
| def logging(all): | ||
| """Clear logging files""" | ||
| if os.path.exists("/var/log.tmpfs"): |
There was a problem hiding this comment.
Do we not plan to delete existing logs in /var/log/ if both the directories /var/log/ and /var/log.tmpfs/ have syslogs?
Signed-off-by: matiAlfaro <mati@marvell.com>
mihirpat1
reviewed
Feb 12, 2024
clear/main.py
Outdated
| @cli.command() | ||
| def logging(all): | ||
| """Clear logging files""" | ||
| log_path_arr = ["/var/log"] |
There was a problem hiding this comment.
Can we put a check here to ensure /var/log directory exists before setting log_path_arr?
Signed-off-by: matiAlfaro <mati@marvell.com>
mihirpat1
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###What I did
Added command
sonic-clear logging - delete syslog & syslog.1
sonic-clear logging -a/--all - delete syslog* files
###How I did it
Equivalent to "show logging" command, working on files at /var/log or at /var/log.tmpfs
delete relevant syslog* files
###How to verify it
clear logging when no syslog files exist
clear logging when only syslog file exist
clear logging when syslog & syslog.1 files exits
clear logging when syslog, syslog.1 and syslog2.gz files exits
Repeat 1-4 with
Clear logging --all
verify also that show logging behave correctly after clear
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)