Utilities Changes for DHCP DoS Mitigation Feature #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asraza07
changed the title
…ttribute is not present"
…/sonic-utilities into dhcp_dos_mitigation_cli
asraza07
force-pushed
the
dhcp_dos_mitigation_cli
branch
from
4918942
to
1c06171
Compare
ridahanif96
approved these changes
Jul 23, 2024
|
@yaqiangz Can you help approved this PR. We are also done with Code Coverage. Thanks in advance! |
|
@qiluo-msft Pls help review this PR. HLD Already Approved. Thanks in advance! |
|
Hi @qiluo-msft can you pls help review this PR. HLD is merged |
yaqiangz
reviewed
Sep 9, 2024
tests/interfaces_test.py
Outdated
| @@ -263,6 +263,13 @@ | |||
| PortChannel1001 trunk 4000 | |||
| """ | |||
|
|
|||
| show_dhcp_rate_limit_in_alias_mode_output = """\ | |||
There was a problem hiding this comment.
The var "show_dhcp_rate_limit_in_alias_mode_output" was added mistakenly and isn't used in the current code. I have removed it to keep the code clean
|
@qiluo-msft pls help merge this one |
|
@qiluo-msft please help review and merge this PR |
|
Please resolve conflict |
Resolving! Thanks for help |
|
/azpw run |
1 similar comment
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qiluo-msft conflicts has been resolved can you please help review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added config interface dhcp-mitigation-rate add/del and show interfaces dhcp-mitigation-rate commands for DHCP mitigation rate attribute in config_db and added support for new attribute in DB Migrator
How I did it
Add/del commands add/remove interface DHCP rate limits defined by the user to PORT_TABLE in config_db and show command reads and displays DHCP rate limits on interfaces in the form of a table