show startupconfiguration bgp is not working for frr #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface status A bug in intfutil script that gets the keys object from the app-db for a specific interface Signed-off-by: kiran.kella@broadcom.com
…stead of the optional alias attribute * Addressed review comment for sonic-net#424 * Undone the change in intfutil file to push that fix in a seperate PR. Signed-off-by: kiran.kella@broadcom.com
…erface-name> startup/shutdown'.
Fix: Print the frr startup config from the right location.
nikos-github
approved these changes
Jan 28, 2019
|
@nikos-github Changes are approved. Can this PR be merged please? |
lguohan
reviewed
May 10, 2019
| @@ -1338,7 +1338,7 @@ def bgp(verbose): | |||
| if result == "quagga": | |||
| run_command('sudo docker exec bgp cat /etc/quagga/bgpd.conf', display_cmd=verbose) | |||
| elif result == "frr": | |||
| run_command('sudo docker exec bgp cat /etc/frr/bgpd.conf', display_cmd=verbose) | |||
| run_command('sudo docker exec bgp cat /etc/sonic/frr/frr.conf', display_cmd=verbose) | |||
There was a problem hiding this comment.
change to /etc/frr/bgpd.conf
lguohan
requested changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Give the correct file path for the frr startup config
- How I did it
/etc/sonic/frr/frr.conf is the startup config for frr.
Corrected this path in the main.py script for displaying the bgp startup configuration.
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
root@sonic:/home/admin# show startupconfiguration bgp
Routing-Stack is: frr
cat: /etc/frr/bgpd.conf: No such file or directory
- New command output (if the output of a command-line utility has changed)
root@sonic:/home/admin# show startupconfiguration bgp
Routing-Stack is: frr
frr version 4.0
frr defaults traditional
hostname sonic
!
router bgp 65100
coalesce-time 1000
neighbor 12.1.1.0 remote-as 65100
!
address-family ipv4 unicast
redistribute connected
exit-address-family
!
line vty
!
-->