Enhancing port utilization percentage calculation for all port speeds #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps and calculated the utilization. This will lead to wrong utilization percentage for other speeds like, 100G, 25G, 10G and 1G. The utilization calculation is changed so that the percentage is calculated based on port speed.
|
retest this please |
1 similar comment
|
retest this please |
|
Retest this please |
|
@Prasanth-KV: The "Retest this please" comments are not directed at you. It is a trigger phrase which causes a GitHub plugin to automatically re-run our check builds. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
The utilization percentage calculation for interfaces is been updated to address all the port speeds. It was calculated for 40G alone previously.
- How I did it
The utilization percentage is based on the port speed. It should be the percentage of traffic rate with respect to the port speed. So the formula is been updated to take the actual port speed instead of 40Gbps.
10Gbps is 1000000 bits per second, NOT 10 * 1024 * 1024 * 1024 bps. This is also fixed in utilization formula.
- How to verify it
show interface counters
This command can be used to verify the utilization percentage at different traffic rates.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->