[config] Enhance the Sonic CLI command "config save" #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enhance the Sonic CLI command "config save" to roll back the existing config file when an error occurs during the operation. Signed-off-by: Charlie Chen <charlie_chen@edge-core.com>
|
@CharlieChenEC , is there any other case other than database service issue where you could potentially observe this failure? |
|
So far I only observe the failure when database service is not ready. |
|
Retest this please |
1 similar comment
|
Retest this please |
|
@prsunny Could you help review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config file when an error occurs during the operation.
Signed-off-by: Charlie Chen charlie_chen@edge-core.com
- What I did
Enhance the Sonic CLI command "config save" to roll back the existing config file when an error occurs during the operation.
- How I did it
Redirect the output of 'SONIC_CFGGEN' to a temp file. Rename/replace the destination config file by the temp file when
'SONIC_CFGGEN' returns zero.
- How to verify it
Stop 'database.service' and execute 'config save -y config_db.json'. The content of the existing file "config_db.json" will not be changed when "config save -y" returns error.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)