-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonic Chassis http-server HLD #1289
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: anamehra <anamehra@cisco.com>
Hi @abdosi , @qiluo-msft , please review. |
http_server_dir=/var/www/tftp | ||
``` | ||
|
||
The service will be added as a new process in docker database-chassis. dockers/docker-database/supervisord.conf.j2 will be modified to support the new service. This service should run only on database-chassis server, which also hosts redis_chassis.server. Other database dockers should not run the http-server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why re-use database docker not starting its own docker for this http_server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lguohan , this feature was discussed in Chassis community group last year and adding http-server docker was one of the options. But as this is a light weight python http-server, community was more in favor of adding a host side http-server feature. A PR was raised for that but that was an issue enabling the http-server on host side as a feature as it required the service to run a docker.
Later in the community discussion it was decided as its needed in 202205 and only for chassis, to add it as a light weight service in database-chassis which only runs for chassis.
This service is only required for Chassis, binds only to midplane/internal network and uses redis_chassis.server IP to bind to host the server.
@abdosi , please add if I missed anything.
Let me know if we need to have a quick meeting to close on this.
Thanks
|
||
### Architecture Design | ||
|
||
The new http-server shall use the current Sonic architecture and shall not require any architecture design change. The server shall run only on the supervisor and inside the existing database-chassis docker, which runs only on supervisor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why put this service in database container? I do not see any dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in database-chassis container which runs only on Supervisor. Please see above comment for more details. Thanks
Signed-off-by: anamehra anamehra@cisco.com
Sonic Chassis network http-server HLD