Clean up ARP ND Suppression and KLISH content #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unsupported content to avoid confusion
hasan-brcm
approved these changes
Apr 6, 2023
| @@ -266,14 +262,6 @@ __Figure 3: Symmetric IRB packet flow__ | |||
| Both asymmetric and symmetric IRB models will be supported in SONiC. | |||
|
|
|||
|
|
|||
|
|
|||
| #### ARP and ND Suppression | |||
There was a problem hiding this comment.
From the changes, my understanding is that you tried to remove previous ARP / ND suppression changes? Is that correct?
There was a problem hiding this comment.
@eddieruan-alibaba yes that's correct
|
what does unsupported content mean here? |
|
@lguohan @eddieruan-alibaba EVPN VxLAN HLD was originally posted by BRCM and merged Jan 2021. Part of the originally planned contribution includes the KLISH CLIs, the ARP and ND Suppression capabilities, but the corresponding code PRs didn't happen. There was a recent enquiry at the community stating the merged HLD claim is inaccurate, hence the content removal in this PR to avoid confusion for folks testing in reference of the HLD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unsupported content to avoid confusion