Token Cache not updates correctly

[jdneo]

The code here:

azure-activedirectory-library-for-nodejs/lib/memory-cache.js

Line 63 in 2badd7c

if (_.isEqual(element, addElement)) {

is using isEqual to check if two token entries are equal or not. But sometimes, addElement is just an update of element, (All the fields are equal except the expiresOn)

For example:

Then, after add method, the token cache will have two tokens which are duplicated.

After that, when we trigger find for the token cache, it will cause More than one token matches the criteria. The result is ambiguous error.

Here:

azure-activedirectory-library-for-nodejs/lib/cache-driver.js

Line 223 in 9aa5672

callback(self._log.createError('More than one token matches the criteria. The result is ambiguous.'));

[prowe]

Could this be resolved by #188 ?

[jdneo]

Looks good. Thanks

[navyasric]

Closing as this seems to be resolved.

[jdneo]

@navyasric

May I ask why you close this issue? The code there hasn't got any updates. The PR referenced by @prowe is still open.