This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Handle token refresh in Azure Stack (ADFS 2016) #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugangw-msft
force-pushed
the
azurestack
branch
from
9f60cb7 to
aeeded6
Compare
bganapa
approved these changes
Aug 23, 2017
viananth
approved these changes
Aug 24, 2017
|
@rayluo, could you please review this? This is a blocking scenario for Azure Stack |
|
Thanks for contributing to identify and resolve this bug. Merged. A new release is coming soon. |
Merged
|
@viananth @bganapa @yugangw-msft FYI: ADAL Python 0.4.7 has been released. As usual, you can get it by |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rayluo, I will add you to a mail thread with more details
For context, Azure Stack environment uses ADFS 2016. When use MRRT (
multi resource refresh token) to get an access token for other resources, server doesn't includeresourcein the response payload because it doesn't return a new refresh token. Note, AAD always returns a new refresh token. The consequence is pretty severe, asresourceis part of the token cache key, and not updating it will corrupt the whole cache.The change is pretty safe. If you are fine with the option, I will go ahead and add a few test coverage.