Public API LoadFirstValidCredentialsAsync still loads skipped credentials

[bgavrilMS]

Microsoft.Identity.Web Library

Microsoft.Identity.Web

Microsoft.Identity.Web version

3.10.0

Web app

Not Applicable

Web API

Not Applicable

Token cache serialization

Not Applicable

Description

1. Create a list of CredentialDescription with 2 credentials, and mark the first one with SKIP=true;
2. Call the public API LoadFirstValidCredentialsAsync(list)

Actual: it loads the first credential, and then it doesn't use it
Expected: do not load the first credential and do not use it.

Reproduction steps

^^

Error message

No response

Id Web logs

No response

Relevant code snippets

CredentialDescription[] credentialDescriptions = new[]
{
    new CredentialDescription
    {
        SourceType = CredentialSource.SignedAssertionFromManagedIdentity,
        Skip = true
    },

    new CredentialDescription
    {
        SourceType = CredentialSource.KeyVault,
        KeyVaultUrl = "https://bogus.net",
        KeyVaultCertificateName = "Self-Signed-5-5-22"
    }
};
await DefaultCredentialLoader.LoadFirstValidCredentialsAsync(credentialDescriptions );


// Actual: credential1 (managed identity) is still attempted.

Regression

No response

Expected behavior

don't load skipped creds

[jmprieur]

Is it a regression?

[jennyf19]

Are you expecting my team to pick this up?

[bgavrilMS]

Good first issue for someone from MSAL team to pick up.