Skip to content

Commit

Permalink
Fix ExtensionInstanceForCreate for import
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathan-innis committed Mar 15, 2021
1 parent 8a269d7 commit 88117e8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def Create(self, cmd, client, resource_group_name, cluster_name, name, cluster_t
_get_container_insights_settings(cmd, resource_group_name, cluster_name, configuration_settings,
configuration_protected_settings, is_ci_extension_type)

# NOTE-2: Return a valid ExtensionInstanceForCreate object, Instance name and flag for Identity
# NOTE-2: Return a valid ExtensionInstance object, Instance name and flag for Identity
create_identity = True
extension_instance = ExtensionInstance(
extension_type=extension_type,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def Create(self, cmd, client, resource_group_name, cluster_name, name, cluster_t
_get_container_insights_settings(cmd, resource_group_name, cluster_name, configuration_settings,
configuration_protected_settings, is_ci_extension_type)

# NOTE-2: Return a valid ExtensionInstanceForCreate object, Instance name and flag for Identity
# NOTE-2: Return a valid ExtensionInstance object, Instance name and flag for Identity
create_identity = True
extension_instance = ExtensionInstance(
extension_type=extension_type,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# --------------------------------------------------------------------------------------------

from abc import ABC, abstractmethod
from azext_k8s_extension.vendored_sdks.models import ExtensionInstanceForCreate
from azext_k8s_extension.vendored_sdks.models import ExtensionInstance
from azext_k8s_extension.vendored_sdks.models import ExtensionInstanceUpdate


Expand All @@ -14,10 +14,10 @@ def Create(self, cmd, client, resource_group_name: str, cluster_name: str, name:
extension_type: str, scope: str, auto_upgrade_minor_version: bool, release_train: str, version: str,
target_namespace: str, release_namespace: str, configuration_settings: dict,
configuration_protected_settings: dict, configuration_settings_file: str,
configuration_protected_settings_file: str) -> ExtensionInstanceForCreate:
configuration_protected_settings_file: str) -> ExtensionInstance:
pass

@abstractmethod
def Update(self, extension: ExtensionInstanceForCreate, auto_upgrade_minor_version: bool,
def Update(self, extension: ExtensionInstance, auto_upgrade_minor_version: bool,
release_train: str, version: str) -> ExtensionInstanceUpdate:
pass

0 comments on commit 88117e8

Please sign in to comment.