Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add service svg's to assets #444

Merged
merged 34 commits into from
Apr 18, 2019
Merged

Add service svg's to assets #444

merged 34 commits into from
Apr 18, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2019

Contributes to #199

Overall change: Add news SVG to assets.

Code changes:

  • Added news SVG group to assets to enable brand accept different svg's while maintaining accessibility.
  • Introduced ratio to allow the svgs scale nicely when an svg height is provided

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

Drew McMillan and others added 2 commits April 15, 2019 11:29
Co-Authored-By: sadickisaac <48688870+sadickisaac@users.noreply.github.com>
@j-pendlebury
Copy link
Contributor

We now have brand SVGs for the 4 services - https://www.dropbox.com/sh/c1arjjhwgxehmbg/AAB3gEXhboYrmLRNFXswihUYa?dl=0

packages/utilities/psammead-assets/README.md Outdated Show resolved Hide resolved
packages/utilities/psammead-assets/src/svgs.jsx Outdated Show resolved Hide resolved
@dr3 dr3 added the ws-home Tasks for the WS Home Team label Apr 16, 2019
amywalkerdev
amywalkerdev previously approved these changes Apr 17, 2019
Copy link
Contributor

@amywalkerdev amywalkerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-Authored-By: sadickisaac <48688870+sadickisaac@users.noreply.github.com>
@ghost ghost dismissed stale reviews from dr3 and amywalkerdev via 7810f16 April 17, 2019 12:48
@ghost ghost requested review from sareh and dr3 April 17, 2019 14:20
@ghost ghost self-assigned this Apr 17, 2019
@ghost ghost requested a review from amywalkerdev April 17, 2019 14:22
Copy link
Contributor

@amywalkerdev amywalkerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 all good!

@jamesbrumpton
Copy link
Contributor

LGTM. Happy for this to be merged.

@dr3 dr3 merged commit 2709092 into latest Apr 18, 2019
@dr3 dr3 deleted the add-news-svg branch April 18, 2019 10:30
@thekp thekp mentioned this pull request Jul 12, 2019
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants