Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Misuse of spatially projects onto in textual definition for occurs in #99

Open
gregfowlerphd opened this issue Aug 22, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@gregfowlerphd
Copy link

Describe the bug

The definition reads:

b occurs in c =Def b is a process or a process boundary & c is a material entity or site & there exists a spatiotemporal region r & b occupies spatiotemporal region r & for all time t, if b exists at t then c exists at t & there exist spatial regions s and s' where b spatially projects onto s at t & c occupies spatial region s' at t & s is a continuant part of s' at t

Let’s start with a minor issue. In the phrase 'for all time t', shouldn’t 'time' be 'times'?

Turning to the main issue: The domain and range for spatially projects onto are specified to be spatiotemporal region and spatial region, respectively. But the italicized clause indicates that it can obtain between a process or process boundary and a spatial region.

Expected behavior

I believe 'b spatially projects onto s' should be changed to 'r spatially projects onto s'. Also, 'time' should probably be changed to 'times'.

@gregfowlerphd gregfowlerphd added the bug Something isn't working label Aug 22, 2024
@alanruttenberg
Copy link
Contributor

I concur that this is a bug and your suggested change looks correct. I will fix it in the source. There is a current issue that the published bfo-core.owl was a derived artifact but it has been edited and so has diverged. Edits will have to be made in both places for now, until the two versions are reconciled.

@alanruttenberg
Copy link
Contributor

One divergance is that the original source does not use the word time, only the variables. Here's the original, corrected.

b occurs in c =Def. b is a process or a process boundary and c is a material entity or immaterial entity
& there exists a spatiotemporal region r and b occupies spatiotemporal region r
& for all t, if b exists at t then c exists at t
& there exist spatial regions s and s' where
r spatially projects onto s at t
& c occupies spatial region s' at t
& s is a continuant part of s' at t [143-BFO]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants