Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashed when save path contains Chinese/Japanese/Korea charactors #12

Closed
fasthold opened this issue Jan 23, 2023 · 4 comments · Fixed by #20
Closed

Crashed when save path contains Chinese/Japanese/Korea charactors #12

fasthold opened this issue Jan 23, 2023 · 4 comments · Fixed by #20
Labels
bug Something isn't working

Comments

@fasthold
Copy link

fasthold commented Jan 23, 2023 •
edited
Loading

OS: Window 11

When select save path which contains Chinese/Japanese/Korea charactors, the GUI crashed.
@BKSalman BKSalman added the bug Something isn't working label Feb 4, 2023
@BKSalman
Copy link
Owner

BKSalman commented Feb 4, 2023 •
edited
Loading

does the crash happen after you choose the path or when you start the download?

also can you give me a directory name that I can use to reproduce this issue?

@BKSalman
Copy link
Owner

closing for no reply

@BKSalman
Copy link
Owner

BKSalman commented Aug 14, 2023 •
edited
Loading

@fasthold this issue could be resolved with a new change I did here #20 can you test it please?

@BKSalman BKSalman reopened this Aug 14, 2023
@BKSalman BKSalman mentioned this issue Aug 14, 2023
Merged
@BKSalman BKSalman linked a pull request Aug 14, 2023 that will close this issue
Better parsing #20
Merged
@BKSalman
Copy link
Owner

I will merge the changes to main, if they don't fix the issue, feel free to reopen the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better parsing BKSalman/ytdlp-gui
2 participants
@fasthold @BKSalman