Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual anomalies on macOS #317

Closed
TheNoswad opened this issue Jan 7, 2022 · 7 comments
Closed

Visual anomalies on macOS #317

TheNoswad opened this issue Jan 7, 2022 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone
v0.3.0

Comments

@TheNoswad
Copy link

When running on macOS Metal, there is a severe flickering of black stripes on meshes. This problem appears to have started after #314

My specs

  • macOS Catalina 10.15.7
  • 1.6 GHz Dual-Core Intel Core i5
  • Intel HD Graphics 6000 1536 MB

Attached is a video of the scene-viewer example exhibiting the issue.

Screen.Recording.2022-01-07.at.9.09.48.AM.mov
@cwfitzgerald cwfitzgerald added bug Something isn't working help wanted Extra attention is needed labels Jan 7, 2022
@cwfitzgerald
Copy link
Member

My guess is this is either a bug in wgpu/naga or a driver bug. It may also be mad at my negative shadow biases, but that would be super strange to me.

@cwfitzgerald
Copy link
Member

cwfitzgerald commented Jan 9, 2022 •
edited
Loading

Took a look at the generated MSL for the new shadow shader and nothing looks terribly amiss.

@scoopr scoopr mentioned this issue Jan 9, 2022
Merged
@cwfitzgerald cwfitzgerald added this to the v0.3.0 milestone Jan 13, 2022
@cwfitzgerald
Copy link
Member

cwfitzgerald commented Jan 13, 2022 •
edited
Loading

This is fixed, just needs to be backported to wgpu 0.12. Marking as a blocker for release.

@cwfitzgerald
Copy link
Member

Fix published in wgpu, closing.

@cwfitzgerald
Copy link
Member

Unfortunately opening this back up, still happens on an M1

image

@cwfitzgerald cwfitzgerald reopened this Jan 23, 2022
@cwfitzgerald cwfitzgerald mentioned this issue Jan 23, 2022
Closed
@cwfitzgerald
Copy link
Member

Fix is in the works

@cwfitzgerald
Copy link
Member

So this now works on MacOS 11+ and iOS 14+, need to follow up with bigger hammers for previous OSs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
2 participants
@cwfitzgerald @TheNoswad